Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version control init pkg and use zarf cache #895

Merged
merged 16 commits into from
Oct 13, 2022

Conversation

jeff-mccoy
Copy link
Contributor

Description

Related Issue

Fixes #839
Fixes #889
Related to #663

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@jeff-mccoy
Copy link
Contributor Author

Note most of the changes are in the /docs/ because of the zarf-cache flag becoming a global flag.

init from the same directory

Screen Shot 2022-10-11 at 3 14 46 PM

init with the init package in the same dir as the binary

Screen Shot 2022-10-11 at 3 15 05 PM

init with the init package in the zarf-cache directory

Screen Shot 2022-10-11 at 5 38 36 PM

init with no local init package found

Screen Shot 2022-10-11 at 5 39 09 PM

@jeff-mccoy jeff-mccoy added bug 🐞 Something isn't working breaking-change labels Oct 12, 2022
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeff-mccoy jeff-mccoy merged commit 659742f into master Oct 13, 2022
@jeff-mccoy jeff-mccoy deleted the version-control-init-pkg-and-use-zarf-cache branch October 20, 2022 04:18
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
2 participants