windows: mouse and keyboard #8791
Conversation
cla-bot
bot
added
the
cla-signed
zaucy
force-pushed
the
windows-mouse-and-keyboard
branch
from
8e20d15 to
5386e34
Compare
| let mut callbacks = self.callbacks.borrow_mut(); | ||
| if let Some(callback) = callbacks.input.as_mut() { | ||
| let modifiers = self.current_modifiers(); | ||
| let msg_char = wparam.0 as u8 as char; |
There was a problem hiding this comment.
https://learn.microsoft.com/en-us/windows/win32/inputdev/wm-char
Since WM_CHAR accepts UTF-16 code units, this conversion can cause problems.
There was a problem hiding this comment.
I agree this is an issue, but I think it should maybe be covered in another PR. I only say this because the char encoding situation is a little wack on windows. Recently they started emphasizing UTF-8 with the RegisterClassA call even tho previously they said new applications should use RegisterClassW.
https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page
Until recently, Windows has emphasized "Unicode" -W variants over -A APIs. However, recent releases have used the ANSI code page and -A APIs as a means to introduce UTF-8 support to apps. If the ANSI code page is configured for UTF-8, then -A APIs typically operate in UTF-8. This model has the benefit of supporting existing code built with -A APIs without any code changes.
That being said I could change this to what this PR does if this is a blocker: https://github.com/zed-industries/zed/pull/8809/files#diff-f5cac42313d3717a63ced25b77b50370494328242025c977fa77d17d5ad1bb40R192-R193
let Ok(first_char) = char::decode_utf16(src).collect::<Vec<_>>()[0] else {
return None;
};There was a problem hiding this comment.
Oh I see. Then we should use -A APIs
Windows mouse and keyboard working! I also tweaked the message loop so that it didn't get stuck. The peek message loop was almost never returning for me during testing.
Release Notes: