Better Windows support #8809
Better Windows support #8809
Conversation
cla-bot
bot
added
the
cla-signed
|
|
@JunkuiZhang this is what my experience was like running the latest commit on this PR when I first do then finally I can resize it to get it visible it behaves like this: sometimes when I click it creates multi cursors as well |
|
This is quite strange. It runs perfectly fine on my end. I will upload a video |
1.mp4 |
|
I use win + G to record this, it dose not record the popups |
@JunkuiZhang: if you are on the latest version of Windows 11 you can also use Win+Shift+S and select the area you want to record :) |
currently, they are just black boxs for me
Thx for the tips! |
@JunkuiZhang I'm so sorry that y'all have to deal with that. Is there another place we could get in touch that's less asynchronous? Regarding the two PRs, as CI is failing on this branch and #8791 handles key events slightly better (e.g. the But that said, I would really love to see the IME support, menus, and etc. in this PR land as well. It's very important that we're usable for everyone and I really appreciate all the work you've put in :) Could you split this work into a few more PRs with fewer changes, maybe one per major feature:
And we could get each of those merged individually? |
Zed is able to get this information from the |
@mikayla-maki If this is Zed's decision. By the way, I have returned to school after the Spring Festival holiday, so once I have submitted all the contents in this PR, I probably won't have that much time for further development. |
|
I understand, thank you for the work you've already put in! |
### Description This is a part of #8809 Update mio from 0.8.8 to 0.8.11. When using named pipes on Windows, mio will under some circumstances return invalid tokens that correspond to named pipes that have already been deregistered from the mio registry. The impact of this vulnerability depends on how mio is used. For some applications, invalid tokens may be ignored or cause a warning or a crash. On the other hand, for applications that store pointers in the tokens, this vulnerability may result in a use-after-free. ### Connections [named-pipes: fix receiving IOCP events after deregister #1760](tokio-rs/mio#1760) [Windows Named pipes invalid memory access #6369](tokio-rs/tokio#6369) Release Notes: - N/A
### Description This is a part of #8809 Release Notes: - N/A
### Description This is a part of #8809 , impl the following functions: - `os_version` - `local_timezone` - `double_click_interval` - `set_cursor_style` - `open_url` - `reveal_path` Release Notes: - N/A --------- Co-authored-by: Mikayla Maki <[email protected]>
### Description This is a part of #8809 https://github.com/zed-industries/zed/assets/14981363/2b085b9d-8b83-4ac7-8b84-07c679760eba Release Notes: - N/A --------- Co-authored-by: Mikayla Maki <[email protected]>
### Description This is a part of #8809 , and this PR dose not include `open file dialog`, as I already saw two PRs impl this. https://github.com/zed-industries/zed/assets/14981363/3223490a-de77-4892-986f-97cf85aec3ae Release Notes: - N/A
As I mentioned before, there are the following issues with how GPUI handles scale factors greater than 1.0: 1. The title bar buttons do not function correctly, with minimizing button performing maximization and maximizing button performing closure. 2. As discussed in #8809, setting a scale factor greater than 1.0 causes GPUI's drawing content to be pushed off the screen. This PR introduces `LogicalSize` and `PhysicalSize` to differentiate between coordinate systems for proper GPUI rendering, and now scale factors above 1.5 are working correctly. `Zed` with a scale factor equals 1.5, and change between different scale factors: https://github.com/zed-industries/zed/assets/14981363/3348536d-8bd3-41dd-82f6-052723312a5b Release Notes: - N/A
As I mentioned before, there are the following issues with how GPUI handles scale factors greater than 1.0: 1. The title bar buttons do not function correctly, with minimizing button performing maximization and maximizing button performing closure. 2. As discussed in zed-industries#8809, setting a scale factor greater than 1.0 causes GPUI's drawing content to be pushed off the screen. This PR introduces `LogicalSize` and `PhysicalSize` to differentiate between coordinate systems for proper GPUI rendering, and now scale factors above 1.5 are working correctly. `Zed` with a scale factor equals 1.5, and change between different scale factors: https://github.com/zed-industries/zed/assets/14981363/3348536d-8bd3-41dd-82f6-052723312a5b Release Notes: - N/A
Edit:
Close #8825
I will add some videos or pics below
Release Notes: