-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: Use exact scale factor #9440
Conversation
Edit: Sorry, I misread that. I'm not sure if the current issues related to the |
Probably There seems to be differences between macOS and Windows in the effect of the scale factor on the size of the window, so there needs to be some changes. |
In second thought, the values to be stored in the database can remain the same. And apply display scale factor on create window. |
https://learn.microsoft.com/en-us/windows/win32/api/shellscalingapi/nf-shellscalingapi-getdpiformonitor#remarks |
f396c55
to
3589ed6
Compare
screenshots and description incoming ## title bar when window is maximized | before | after | | --- | --- | | ![image](https://github.com/zed-industries/zed/assets/1284289/075a943d-54db-4b71-9fa0-15f823255182) | ![image](https://github.com/zed-industries/zed/assets/1284289/39a1d381-fcfd-4651-aab4-231a8ec3bd99) | ## ~~caption buttons at 200%~~ ~~buttons are now properly responsive at different scales~~ ~~closes #9438~~ ~~proper scale factor handling in follow up PR (possibly #9440)~~ <details> <summary>out of date image</summary> ![scale-factor](https://github.com/zed-industries/zed/assets/1284289/299d37b8-0d2e-4f2e-81db-2fff6fc59a62) </details> should be fixed by #9456 Release Notes: - N/A
screenshots and description incoming ## title bar when window is maximized | before | after | | --- | --- | | ![image](https://github.com/zed-industries/zed/assets/1284289/075a943d-54db-4b71-9fa0-15f823255182) | ![image](https://github.com/zed-industries/zed/assets/1284289/39a1d381-fcfd-4651-aab4-231a8ec3bd99) | ## ~~caption buttons at 200%~~ ~~buttons are now properly responsive at different scales~~ ~~closes zed-industries#9438~~ ~~proper scale factor handling in follow up PR (possibly zed-industries#9440)~~ <details> <summary>out of date image</summary> ![scale-factor](https://github.com/zed-industries/zed/assets/1284289/299d37b8-0d2e-4f2e-81db-2fff6fc59a62) </details> should be fixed by zed-industries#9456 Release Notes: - N/A
Maybe several problem in this will be solved by #9438, I wait it.
Also below is remained task.
Release Notes: