windows: Fix incorrect titlebar behavior with a scale factor greater than 1.0 #9438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
1 task
kazatsuyu
reviewed
Mar 16, 2024
| @@ -1593,3 +1596,4 @@ fn oemkey_vkcode_to_string(code: u16) -> Option<String> { | |||
|
|
|||
| // https://learn.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-dragqueryfilew | |||
| const DRAGDROP_GET_FILES_COUNT: u32 = 0xFFFFFFFF; | |||
| const DEFAULT_DPI_VALUE: u32 = 96; | |||
There was a problem hiding this comment.
We can use USER_DEFAULT_SCREEN_DPI
zaucy
reviewed
Mar 16, 2024
| let frame_y = unsafe { GetSystemMetricsForDpi(SM_CYFRAME, dpi) }; | ||
| let padding = unsafe { GetSystemMetricsForDpi(SM_CXPADDEDBORDER, dpi) }; | ||
| // let dpi = unsafe { GetDpiForWindow(self.hwnd) }; | ||
| let frame_x = unsafe { GetSystemMetricsForDpi(SM_CXFRAME, USER_DEFAULT_SCREEN_DPI) }; |
There was a problem hiding this comment.
I don't think we need to go to using USER_DEFAULT_SCREEN_API here and instead use these values in the platform titlebar which are existing TODOs
There was a problem hiding this comment.
done here. #9449
@JunkuiZhang give it a try!
|
Should be addressed by #9456 |
maxdeviant
changed the title
mikayla-maki
pushed a commit
that referenced
this pull request
Mar 20, 2024
screenshots and description incoming ## title bar when window is maximized | before | after | | --- | --- | |  |  | ## ~~caption buttons at 200%~~ ~~buttons are now properly responsive at different scales~~ ~~closes #9438~~ ~~proper scale factor handling in follow up PR (possibly #9440)~~ <details> <summary>out of date image</summary>  </details> should be fixed by #9456 Release Notes: - N/A
pjlast
pushed a commit
to pjlast/zed
that referenced
this pull request
Mar 26, 2024
screenshots and description incoming ## title bar when window is maximized | before | after | | --- | --- | |  |  | ## ~~caption buttons at 200%~~ ~~buttons are now properly responsive at different scales~~ ~~closes zed-industries#9438~~ ~~proper scale factor handling in follow up PR (possibly zed-industries#9440)~~ <details> <summary>out of date image</summary>  </details> should be fixed by zed-industries#9456 Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue where the titlebar functionality was not working correctly when the scale factor was greater than 1.0.
As I mentioned in #8809 , support for scale factors greater than 1.0 will require more efforts on the
bladeside.Titlebar incorrect behaviour (with scale factor 1.5):
8.mp4
Release Notes: