drivers: pinctrl: stm32: fix F1 SWJ_CFG application #43605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeCGV
requested review from
gmarull,
erwango,
ABOSTM and
FRASTM
as code owners
GeorgeCGV
force-pushed
the
rework_f103_pin_remap
branch
7 times, most recently
from
df0396d to
416640e
Compare
erwango
reviewed
Mar 10, 2022
erwango
reviewed
Mar 10, 2022
FRASTM
reviewed
Mar 11, 2022
Removed SWJ_CFG initialization. The functionality is moved into pinctrl / pinmux modules. Signed-off-by: Georgij Cernysiov <[email protected]>
github-actions
bot
added
area: Devicetree
area: Devicetree Binding
The Serial Wire JTAG configuration is moved to F1 pinctrl DTS. The configuration in GPIO didn't apply to the majority of the STM MCUs except F1. Signed-off-by: Georgij Cernysiov <[email protected]>
GeorgeCGV
force-pushed
the
rework_f103_pin_remap
branch
3 times, most recently
from
29b5490 to
1b446bf
Compare
erwango
requested changes
Mar 14, 2022
erwango
reviewed
Mar 14, 2022
Adds 'swj-cfg' property to the F1 pinctrl. It is an optional property that allows to control Serial Wire JTAG configuration. Different configurations allow to free certain IO pins that can be used in remap or standalone. That replaces previously used Kconfig approach. Signed-off-by: Georgij Cernysiov <[email protected]>
GeorgeCGV
force-pushed
the
rework_f103_pin_remap
branch
3 times, most recently
from
c18fdca to
f601aec
Compare
erwango
requested changes
Mar 14, 2022
- Move SWJ_CFG initialization into pinctrl. - Don't disable the AFIO clock after SWJ_CFG initialization. - Apply '111' to the SWJ_CFG bits upon remap application, that fixes the remap usage. Signed-off-by: Georgij Cernysiov <[email protected]>
- Move SWJ_CFG initialization into pinmux. - Don't disable the AFIO clock after SWJ_CFG initialization. - Apply '111' to the SWJ_CFG bits upon remap application, that fixes the remap usage. Signed-off-by: Georgij Cernysiov <[email protected]>
STM32 F1 SWJ_CFG Kconfig options were removed in favor of pinctrl/pinmux device tree properties. Signed-off-by: Georgij Cernysiov <[email protected]>
GeorgeCGV
force-pushed
the
rework_f103_pin_remap
branch
from
f601aec to
7e961bb
Compare
github-actions
bot
added
area: Documentation
Release Notes
FRASTM
approved these changes
Mar 14, 2022
erwango
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on
LLandHALlibraries the value ofAFIO_MAPR_SWJ_CFGhas to be applied to theMAPRupon enabling of a remap. That solved the issue of a not working SPI 1 remap on F103VC and allowed it to be debuggable when theCONFIG_GPIO_STM32_SWJ_NOJTAGoption is enabled.The SWJ CFG initialization into
pinctrl/pinmux(deprecated) modules.Kconfig SWJ options were moved into F1
pinctrl/pinmuxDTS.Fixes #43452
Fixes #43640
Signed-off-by: Georgij Cernysiov [email protected]