Bluetooth: Controller: llcp: Fix assert if LL_REJECT_IND PDU received while local and remote control procedure is pending #45853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppryga-nordic
requested review from
carlescufi,
cvinayak,
thoh-ot and
kruithofa
as code owners
ppryga-nordic
force-pushed
the
github-ble-llcp-fix-assert-when-ll-reject-received
branch
from
e365c26 to
f49d72e
Compare
ppryga-nordic
added
bug
ppryga-nordic
force-pushed
the
github-ble-llcp-fix-assert-when-ll-reject-received
branch
2 times, most recently
from
8f1e460 to
2638711
Compare
cvinayak
previously approved these changes
May 23, 2022
In case there are pending two control procedures: local and remote, and remote device sends LL_REJECT_IND PDU then assertion happened. ull_cp_rx function triggers assertion because LL_REJECT_IND is considered as expected packet for all local and remote control procedures. That is not correct. It does not allow local procedure to handle a response and stops a device on assert. A remote device should not send LL_REJECT_IND PDU for locally initiated control procedures, hence local device should not expect to receive LL_REJECT_IND PDU to be expected one for pending remote control procedure. Remote device is allowed to send LL_REJECT_EXT_IND PDU for a locally initiated control procedures. The LL_REJECT_EXT_IND PDU has a Reject- Opcode that identifies rejected control procedure, hence is may be expected by local device. The commit provides changes that prevent the Controller assertion in described case. Signed-off-by: Piotr Pryga <[email protected]>
ppryga-nordic
force-pushed
the
github-ble-llcp-fix-assert-when-ll-reject-received
branch
from
2638711 to
13cf08a
Compare
|
Fixed an error that make the UT to fail. |
kruithofa
approved these changes
May 24, 2022
cvinayak
approved these changes
May 25, 2022
ppryga-nordic
deleted the
github-ble-llcp-fix-assert-when-ll-reject-received
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there are pending two control procedures: local and remote,
and remote device sends LL_REJECT_IND PDU then assertion happened.
ull_cp_rx function triggers assertion because LL_REJECT_IND is
considered as expected packet for all local and remote control
proceures.
That is not correct. It does not allow local procedure to handle
a response and stops a device on assert.
A remote device should not send LL_REJECT_IND PDU for locally initiated
control procedures, hence local device should not expect to receive
LL_REJECT_IND PDU to be expected one for pending remote control
procedure.
Remote device is allowed to send LL_REJECT_EXT_IND PDU for a locally
initiated control procedures. The LL_REJECT_EXT_IND PDU has a Reject-
Opcode that identifies rejected control procedure, hence is may be
expected by local device.
The commit provides changes that prevent the Controller assertion
in described case.
Signed-off-by: Piotr Pryga [email protected]