Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unmuted topics in muted streams #5362

Closed
3 tasks
alya opened this issue Apr 27, 2022 · 4 comments · Fixed by #5727
Closed
3 tasks

Support unmuted topics in muted streams #5362

alya opened this issue Apr 27, 2022 · 4 comments · Fixed by #5727
Assignees
Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release.

Comments

@alya
Copy link
Collaborator

alya commented Apr 27, 2022

In zulip/zulip#2517, we are implementing an option to make a topic inside a muted stream as unmuted.

In this case, we should treat the topic as unmuted in the mobile app as well. This includes:

  • Showing the topic alongside other unmuted topics in All messages and the inbox view
  • @-mention notifications
  • Ideally matching the webapp UI for how the topic is displayed in streams, which likely means:
    • For muted streams, replacing the stream unread count with the unread count total for the unmuted topics in that stream, if there are any such unreads.
    • In muted streams, sorting unmuted topics at the top in the stream topic view.

Note that because the feature has not been completed and the webapp UX has not been tested, details of the webapp UI may change.

@alya alya added P1 high-priority webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. server release goal Things we should try to coordinate with a major Zulip Server release. labels Apr 27, 2022
@gnprice
Copy link
Member

gnprice commented May 12, 2022

From that zulip/zulip thread, it looks like we don't yet have a prototype implementation for the server side, so this isn't ripe to actually build until we do.

However, there is zulip/zulip#21251, which makes a preparatory change to the API. Making that change (and clients moving over to use it) doesn't yet cause any change to user-visible behavior; but it reorganizes how we represent muting a topic, in a way that we'll use as a basis for adding the feature of unmuting a topic. So the thing that is ripe for us to do now on mobile is to implement our side of that API change. I'll file an issue for that and pick it up.

@gnprice gnprice added blocked on other work To come back to after another related PR, or some other task. and removed webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. labels May 12, 2022
@gnprice
Copy link
Member

gnprice commented May 12, 2022

Added "blocked on other work" because this blocks on at least a prototype of a backend implementation. Removed "webapp parity" because this is a feature that doesn't yet exist on web (though as "server release goal" indicates, it's one we hope to have on web pretty soon.)

@gnprice gnprice removed P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. labels Jun 9, 2022
@chrisbobbe chrisbobbe added the server release goal Things we should try to coordinate with a major Zulip Server release. label Aug 11, 2022
@chrisbobbe
Copy link
Contributor

#5382 is for using the new API.

@gnprice gnprice removed the server release goal Things we should try to coordinate with a major Zulip Server release. label Sep 1, 2022
@gnprice gnprice added P1 high-priority and removed blocked on other work To come back to after another related PR, or some other task. labels Mar 9, 2023
@gnprice
Copy link
Member

gnprice commented Mar 9, 2023

Relabeling because the server-side implementation has landed: zulip/zulip#24236 and we're again hoping to ship this feature in general sometime not too far in the future.

@gnprice gnprice added the server release goal Things we should try to coordinate with a major Zulip Server release. label Mar 15, 2023
@gnprice gnprice self-assigned this Mar 15, 2023
@alya alya added this to 7.0 release Apr 11, 2023
gnprice added a commit to gnprice/zulip-mobile that referenced this issue Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants