Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI to unmute a topic in a muted stream #5691

Closed
Tracked by #25216
gnprice opened this issue Mar 21, 2023 · 3 comments · Fixed by #5727
Closed
Tracked by #25216

UI to unmute a topic in a muted stream #5691

gnprice opened this issue Mar 21, 2023 · 3 comments · Fixed by #5727
Assignees
Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release.

Comments

@gnprice
Copy link
Member

gnprice commented Mar 21, 2023

This is a companion to #5362, as part of the feature zulip/zulip#2517.

Issue #5362 is for respecting the setting once a user has set it, perhaps through the web app. This issue is for offering UI to set it in the first place.

The existing UI for muting a topic, and for making a topic no longer muted, is in the topic action sheet, which you get by long-pressing on a topic. (Either on the inbox screen, or in the list of topics for a stream, or as the title in the app bar on a topic narrow's message list, or as a recipient header inside the message list.)

Probably that will be the natural place for the new UI too. Here's the UI we have planned for web (in zulip/zulip#24243 ):

For topics in muted streams, replace the "Mute topic" option in the three-dot topic menu with an "Unmute topic" option, which should make the topic unmuted. For unmuted topics in muted streams, show the regular "Mute topic" option, which should specifically mark the topic as muted, as usual.

We should aim for something analogous in mobile. /cc @alya for thoughts on the desired UI.

@gnprice gnprice added P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. labels Mar 21, 2023
@abdulmoiz37

This comment was marked as off-topic.

@alya
Copy link
Collaborator

alya commented Mar 22, 2023

Yeah, using the topic action sheet, with the logic quoted from the web issue for what option to show, sounds good to me.

@gnprice

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants