Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Freeze while typing (Samsung) #5729

Closed
chrisbobbe opened this issue Apr 28, 2023 · 0 comments · Fixed by #5730
Closed

Android: Freeze while typing (Samsung) #5729

chrisbobbe opened this issue Apr 28, 2023 · 0 comments · Fixed by #5730
Labels
a-Android a-compose/send Compose box, autocomplete, camera/upload, outbox, sending P1 high-priority performance Issues related to improving performance (speed, latency, battery usage, etc)

Comments

@chrisbobbe
Copy link
Contributor

We've had a few reports of the keyboard freezing on Samsung devices. Details: https://chat.zulip.org/#narrow/stream/48-mobile/topic/freeze.20while.20typing.20.28Samsung.20Galaxy.20S21.29/near/1507199

We suspect facebook/react-native#35936. RN's fix has recently been backported to v68 in v0.68.7 (facebook/react-native#35936 (comment)) so we should upgrade to that.

We haven't yet managed to reproduce the issue ourselves, but hopefully the fix is good. The symptoms in the reports we've gotten have been bad.

@chrisbobbe chrisbobbe added a-Android a-compose/send Compose box, autocomplete, camera/upload, outbox, sending performance Issues related to improving performance (speed, latency, battery usage, etc) labels Apr 28, 2023
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 28, 2023
Aimed at fixing zulip#5729.

This small upgrade is nice and easy; the upgrade helper doesn't show
any other changes we need to make:
  https://react-native-community.github.io/upgrade-helper/?from=0.68.5&to=0.68.7

Release notes:
  https://github.com/facebook/react-native/releases/tag/v0.68.7

Incidentally we also get facebook/react-native@c3ad8ec7e in this
release, which makes the change we've been patching in with
`patch-package` to fix an Xcode build failure, so we can remove our
`patch-package` patch.

Tested on an iOS simulator (iPhone 14 Pro running iOS 16.4), and on
the office Android device (Samsung Galaxy S9 running Android 9). We
haven't managed to reproduce zulip#5729 ourselves so I can't report an
observation of how this upgrade affects that issue. But upstream
discussion is promising, and from a quick look nothing seems to
break.

Fixes: zulip#5729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-Android a-compose/send Compose box, autocomplete, camera/upload, outbox, sending P1 high-priority performance Issues related to improving performance (speed, latency, battery usage, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant