deps: Upgrade to RN v0.68.7, from v0.68.5 #5730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
a-Android
P1 high-priority
performance
Aimed at fixing zulip#5729. This small upgrade is nice and easy; the upgrade helper doesn't show any other changes we need to make: https://react-native-community.github.io/upgrade-helper/?from=0.68.5&to=0.68.7 Release notes: https://github.com/facebook/react-native/releases/tag/v0.68.7 Incidentally we also get facebook/react-native@c3ad8ec7e in this release, which makes the change we've been patching in with `patch-package` to fix an Xcode build failure, so we can remove our `patch-package` patch. Tested on an iOS simulator (iPhone 14 Pro running iOS 16.4), and on the office Android device (Samsung Galaxy S9 running Android 9). We haven't managed to reproduce zulip#5729 ourselves so I can't report an observation of how this upgrade affects that issue. But upstream discussion is promising, and from a quick look nothing seems to break. Fixes: zulip#5729
|
Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aimed at fixing #5729.
This small upgrade is nice and easy; the upgrade helper doesn't show any other changes we need to make:
https://react-native-community.github.io/upgrade-helper/?from=0.68.5&to=0.68.7
Release notes:
https://github.com/facebook/react-native/releases/tag/v0.68.7
Incidentally we also get facebook/react-native@c3ad8ec7e in this release, which makes the change we've been patching in with
patch-packageto fix an Xcode build failure, so we can remove ourpatch-packagepatch.Tested on an iOS simulator (iPhone 14 Pro running iOS 16.4), and on the office Android device (Samsung Galaxy S9 running Android 9). We haven't managed to reproduce #5729 ourselves so I can't report an observation of how this upgrade affects that issue. But upstream discussion is promising, and from a quick look nothing seems to break.
Fixes: #5729