Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file_options_changed #2099

Merged
merged 3 commits into from
Feb 11, 2023

Conversation

devyetii
Copy link
Contributor

@devyetii devyetii commented Feb 10, 2023

Fixes

  • Some sdk clients don't yet support allocation file options, so till it's added I'll add an indication to mention if the client actually changed file options or not.

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #2099 (326ac35) into staging (890a657) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging    #2099      +/-   ##
===========================================
- Coverage    26.51%   26.50%   -0.02%     
===========================================
  Files          373      373              
  Lines        61603    61609       +6     
===========================================
- Hits         16336    16327       -9     
- Misses       43333    43349      +16     
+ Partials      1934     1933       -1     
Flag Coverage Δ
Unit-Tests 26.50% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...o/0chain.net/smartcontract/storagesc/allocation.go 51.85% <25.00%> (-0.24%) ⬇️
...de/go/0chain.net/smartcontract/vestingsc/config.go 48.94% <0.00%> (-4.74%) ⬇️
...ain.net/smartcontract/storagesc/config_settigns.go 54.76% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/allocation-file-options-not-supported-by-some-clients
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain fix/file-options-not-supported-by-some-sdk-clients
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterlimg
Copy link
Member

@devyetii please check system tests errors

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/allocation-file-options-not-supported-by-some-clients
gosdk NOT OVERRIDDEN
zboxcli fix/file-options-not-supported-by-some-sdk-clients
zwalletcli staging
0chain fix/file-options-not-supported-by-some-sdk-clients
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@dabasov dabasov merged commit 12cf2b9 into staging Feb 11, 2023
@dabasov dabasov deleted the fix/file-options-not-supported-by-some-sdk-clients branch February 11, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants