Add file_options_changed #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devyetii
requested review from
peterlimg,
dabasov,
guruhubb and
cnlangzi
as code owners
3 tasks
dabasov
reviewed
Feb 10, 2023
zboxcore/sdk/sdk.go
Outdated
| mask = updateMaskBit(mask, 5, !fop.ForbidRename.Value) | ||
| } | ||
|
|
||
| return mask | ||
| return changed, mask |
There was a problem hiding this comment.
is changed the same as initial == mask?
There was a problem hiding this comment.
I got your point, I'll use initial == mask instead, nice one btw 👌
…ithub.com:0chain/gosdk into fix/add-file-options-to-create-allocation-request
3 tasks
|
Manual system tests [success] with the following config
|
dabasov
deleted the
fix/add-file-options-to-create-allocation-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
-Some sdk clients don't yet support allocation file options, so till it's added I'll add an indication to mention if the client actually changed file options or not.
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):