Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/file options not supported by some sdk clients #353

Merged
merged 4 commits into from
Feb 11, 2023

Conversation

devyetii
Copy link
Contributor

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/allocation-file-options-not-supported-by-some-clients
gosdk NOT OVERRIDDEN
zboxcli fix/file-options-not-supported-by-some-sdk-clients
zwalletcli staging
0chain fix/file-options-not-supported-by-some-sdk-clients
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit b35095c into staging Feb 11, 2023
@cnlangzi cnlangzi deleted the fix/file-options-not-supported-by-some-sdk-clients branch February 15, 2023 10:23
peterlimg added a commit that referenced this pull request Feb 16, 2023
* staging:
  update gosdk to staging
  Fix incorrect timestamp convert
  Update gosdk
  debugged
  made common.TimeStamp to time.Time for stakedAt
  converted StakedAt to time.Time
  Fix/file options not supported by some sdk clients (#353)
  Remove allocation name (#346)
  NFT changes (#335)
  clean up: collab command
  fix(listall): fixed json output (#348)
  upgrade GoSDK to v1.8.12 (#349)
  fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342)
  feat(list): exported created_at and updated_at (#345)
peterlimg added a commit that referenced this pull request Feb 16, 2023
* staging:
  update gosdk to staging
  Fix incorrect timestamp convert
  Update gosdk
  debugged
  made common.TimeStamp to time.Time for stakedAt
  converted StakedAt to time.Time
  Fix/file options not supported by some sdk clients (#353)
  Remove allocation name (#346)
  NFT changes (#335)
  clean up: collab command
  fix(listall): fixed json output (#348)
  upgrade GoSDK to v1.8.12 (#349)
  fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342)
  feat(list): exported created_at and updated_at (#345)
peterlimg added a commit that referenced this pull request Feb 19, 2023
* staging:
  update gosdk to staging
  Fix incorrect timestamp convert
  Update gosdk
  debugged
  made common.TimeStamp to time.Time for stakedAt
  converted StakedAt to time.Time
  Fix/file options not supported by some sdk clients (#353)
  Remove allocation name (#346)
  NFT changes (#335)
  clean up: collab command
  fix(listall): fixed json output (#348)
  upgrade GoSDK to v1.8.12 (#349)
  fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342)
  feat(list): exported created_at and updated_at (#345)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants