Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembly signing #10

Open
drvic10k opened this issue Aug 27, 2019 · 2 comments
Open

Assembly signing #10

drvic10k opened this issue Aug 27, 2019 · 2 comments

Comments

@drvic10k
Copy link

The assembly available from NuGet is not signed, which is creating a problem when using in a project that is signed
@22222
Copy link
Owner

22222 commented Aug 29, 2019

I'm not sure if I want to get into assembly signing for this library, but I'll at least consider it.

If you need a quick fix, I'd recommend just copying the source code directly into your signed project.

22222 added a commit that referenced this issue Sep 1, 2019
@22222
Enable assembly signing (#10)
490414a 
The keyfile is intentionally included based on Microsoft's advice:

> If you are an open-source developer and you want the identity benefits of a
> strong-named assembly, consider checking in the private key associated with
> an assembly into your source control system.
22222 added a commit that referenced this issue Sep 1, 2019
@22222
Enable assembly signing (#10)
d35617c 
The keyfile is intentionally included based on Microsoft's advice:

> If you are an open-source developer and you want the identity benefits of a
> strong-named assembly, consider checking in the private key associated with
> an assembly into your source control system.
@22222
Copy link
Owner

22222 commented Sep 1, 2019

I added a preview release of the signed assembly to NuGet with version 1.2.2-preview. If you get a chance to try that version with your project the requires a signed assembly, let me know if you run into any issues with it.

I created pull request #11 with the changes but I won't merge it in right away. If anyone sees any problems with that implementation, feel free to comment on it.

@22222 22222 mentioned this issue Apr 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@22222 @drvic10k