Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign CsvTestFieldsParser assembly #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dingdonglars
Copy link

HI. I am really happy to have found your assembly. I am using the Visual Basic one for a net6.0 application, but now I also need the functionality from a Net Standard library. So your library is just what I need. But for my app to use it, it must be signed. Would consider merging this little PR to sign the assembly, please

@dingdonglars
Copy link
Author

A little reminder ping. Are you no longer working on this repo?

@22222
Copy link
Owner

22222 commented Apr 17, 2023

I apologize for not responding. I'd started looking into this, but got distracted by something else and forgot to come back to it.

Someone actually requested this once before (#10), and I've got an open pull request for it in #11. I don't really have a way to test if the assembly signing is working correctly, so I was waiting to merge it in until someone who needs assembly signing can try it out.

It's a little out of date now, but I've got a signed assembly deployed as a NuGet prerelease package version 1.2.2-preview. If you're still interested, would you be able to try out that version and see if it works for you? If it does, I'll merge in one of these pull requests.

@dingdonglars
Copy link
Author

Great! Tnx for your swift reply! I have just removed my temp build of the signed dll and referenced your preview nuget package instead. The library from nuget is signed just fine.

Will you promote your preview version? Then I'll use your nuget package and get rid of my hack

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants