Enable assembly signing (#10) #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keyfile is intentionally included based on Microsoft's advice: > If you are an open-source developer and you want the identity benefits of a > strong-named assembly, consider checking in the private key associated with > an assembly into your source control system.
Open
22222
force-pushed
the
master
branch
3 times, most recently
from
36c2858
to
53caad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables assembly signing in the CsvTextFieldParser project.
One question is whether the private key should be kept a secret or if it should be checked in. I decided to check in the keyfile based on Microsoft's advice in Strong-Named Assemblies:
Which also says:
More documentation about strong naming: