Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1.8 commits and release notes #319

Merged
merged 15 commits into from
May 21, 2023

Commits on May 18, 2023

  1. Check return status of extractSHRT in computeRSMatrix (AcademySoftwar…

    …eFoundation#300)
    
    Technically it's not necessary since extractSHRT will throw since the
    exc argument is implicitly true, but without testing the result, it
    generates a compiler warning.
    
    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed May 18, 2023
    Configuration menu
    Copy the full SHA
    3d7bf75 View commit details
    Browse the repository at this point in the history
  2. Fix coverage analysis for .c files (AcademySoftwareFoundation#306)

    * Fix coverage analysis for .c files
    
    Looks like the coverage analysis has been completely missing .c files.
    
    - Set CMAKE_C_FLAGS/CMAKE_C_OUTPUT_EXTENSION_REPLACE just like CXX
    
    - Fix run_gcov.sh to deduce the source file by examining the .o.d file
      rather than simply replacing .gcno with .cpp, which misses .c files
    
    - Add ImathHalfPerfTest to the test suite
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * confirm dependency file exists
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    ---------
    
    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ab1d9c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3eccc41 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7979844 View commit details
    Browse the repository at this point in the history
  5. Extend test code coverage and add missing python bindings (AcademySof…

    …twareFoundation#305)
    
    * Extend test suite coverage
    
    - Add ImathHalfPerfTest as a test (it was built but not executed)
    - Box<T>::isInfinite() tests
    - Box<T>::affineTransform() tests with empty+infinite boxes
    - rgb2hsv/hsv2rgb
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * typo
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * typo AcademySoftwareFoundation#2
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * Extend test coverage of matrix classes
    
    - Add test code to python test for various operators that were not covered
    
    - In Matrix22 and Matrix33, the python bindings now call setScale(s)
      directly rather than calling setScale(Vec(s)). The behavior is the
      same, but this ensures the scalar version of the method gets test coverage.
    
    - In Matrix44:
    
      * Call setScale(s) in place of setScale(Vec(s)), same as above.
    
      * Similarly, call setShear(s) in place of setShear(Shear(s)). Same
        behavior, better test.
    
      * Add bindings for setEulerAngles() and setAxisAngles(), and
        associated tests.
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * remove commented-out line
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * include <sstream>
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * Imath.half_perf_test
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    ---------
    
    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ec56573 View commit details
    Browse the repository at this point in the history
  6. Extend test coverage (AcademySoftwareFoundation#310)

    * PyImathTestC
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * Random, Color, Frustum, PyImathTestC
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * Python_VERSION
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * set PYTHONPATH property
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * remove <iostream>
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    ---------
    
    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed May 18, 2023
    Configuration menu
    Copy the full SHA
    9977bec View commit details
    Browse the repository at this point in the history
  7. Remove duplicate IMATH_HOSTDEVICE (AcademySoftwareFoundation#314)

    Somehow, a couple methods got duplicate IMATH_HOSTDEVICE attributes,
    presumably a benign typo.
    
    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed May 18, 2023
    Configuration menu
    Copy the full SHA
    13c72b3 View commit details
    Browse the repository at this point in the history
  8. IMATH_EXPORT for Rand32::nextf() (AcademySoftwareFoundation#313)

    Export just the one non-line method, not the entire class.
    
    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed May 18, 2023
    Configuration menu
    Copy the full SHA
    6133b99 View commit details
    Browse the repository at this point in the history
  9. Updated Mac and Windows jobs for VFX platform 2023.

    Signed-off-by: Christina Tempelaar-Lietz <[email protected]>
    xlietz authored and cary-ilm committed May 18, 2023
    Configuration menu
    Copy the full SHA
    978ab39 View commit details
    Browse the repository at this point in the history
  10. Separate CI job for docs (AcademySoftwareFoundation#318)

    * Separate CI job for Docs
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * Replace macOS 10.15 with macOS 12.0
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    ---------
    
    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed May 18, 2023
    Configuration menu
    Copy the full SHA
    9b618bb View commit details
    Browse the repository at this point in the history
  11. Remove unused variables (AcademySoftwareFoundation#303)

    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed May 18, 2023
    Configuration menu
    Copy the full SHA
    63d7459 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Conditionally include Matrix constructors duplicated by interop decla…

    …rations (AcademySoftwareFoundation#307)
    
    * Conditionally include Matrix constructors duplicated by interop declarations
    
    From the code coverage analysis, the ``Matrix44<>(const T a[4][4])``
    constructors are overshadowed by the interoperability constructors
    that match types with double-index operators. This change includes
    them only if the interoperability constructors are disabled at compile
    time.
    
    It also adds a test to validate compilation with the interoperability
    constructurs disabled.
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * testNoInterop.{cpp,h}
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    * remove debugging code
    
    Signed-off-by: Cary Phillips <[email protected]>
    
    ---------
    
    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed May 19, 2023
    Configuration menu
    Copy the full SHA
    bbc0f7a View commit details
    Browse the repository at this point in the history
  2. PR AcademySoftwareFoundation#307 was incorrect, the array-based const…

    …ructors are, in fact, (AcademySoftwareFoundation#309)
    
    necessary.  Although constructing a matrix from a 2D-array variable
    invokes the interop constructor:
    ```
        const float a[2][2] = {{1,0},{0,1}};
        M22f m(a);
    ```
    constructing a matrix from a 2D array *parameter* uses the array
    constructor, which AcademySoftwareFoundation#307 thought was never used, because it was never
    invoked by the test suite:
    ```
        void foo (const float a[2][2])
        {
            M22f m(a);
        }
    ```
    This restores the constructors and adds a test.
    
    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed May 19, 2023
    Configuration menu
    Copy the full SHA
    5c2ebbe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b3ea9f2 View commit details
    Browse the repository at this point in the history
  4. v3.1.8 commits and release notes

    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed May 19, 2023
    Configuration menu
    Copy the full SHA
    751c164 View commit details
    Browse the repository at this point in the history