Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover aghnet package with tests #2846

Open
EugeneOne1 opened this issue Mar 19, 2021 · 4 comments
Open

Cover aghnet package with tests #2846

EugeneOne1 opened this issue Mar 19, 2021 · 4 comments
Assignees
@EugeneOne1
Labels
enhancement P4: Low recurrent Issues about things that need to be done several times.
Milestone
v0.109.0

Comments

@EugeneOne1
Copy link
Member

The aghnet has a coverage of about 30%. It's unacceptable for us. The key sources of uncovered code are the files for Windows.
@EugeneOne1 EugeneOne1 self-assigned this Mar 22, 2021
@EugeneOne1 EugeneOne1 added this to the v0.107.0 milestone Mar 22, 2021
adguard pushed a commit that referenced this issue Mar 22, 2021
@EugeneOne1
Pull request: 2704 local resolvers vol.1
3b2f5d7 
Merge in DNS/adguard-home from 2704-local-addresses-vol.1 to master

Updates #2704.
Updates #2829.
Updates #2846.

Squashed commit of the following:

commit 9a49b3d
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 22 15:39:17 2021 +0300

    aghnet: imp docs and logging

commit 74f95a2
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:56:51 2021 +0300

    all: fix friday evening mistakes

commit 0e2066b
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:51:15 2021 +0300

    all: upd testify, imp code quality

commit 8237c50
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:19:29 2021 +0300

    aghnet: imp test naming

commit 14eb1e1
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 19:41:43 2021 +0300

    aghnet: isolate windows-specific functionality

commit d461ac8
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 14:50:05 2021 +0300

    aghnet: imp code quality

commit d0ee01c
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 11:59:10 2021 +0300

    all: mv funcs to agherr, mk system resolvers getter
@ainar-g ainar-g modified the milestones: v0.107.0, v0.107.1 Dec 13, 2021
adguard pushed a commit that referenced this issue Dec 23, 2021
@EugeneOne1
Pull request: 3987 Fix nil pointer dereference
201ef10 
Merge in DNS/adguard-home from 3987-fix-nil-deref to master

Updates #3987.
Updates #2846.

Squashed commit of the following:

commit d653e09
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 20:08:51 2021 +0300

    all: log changes

commit c47a4ee
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 19:22:39 2021 +0300

    aghnet: fix windows tests

commit 9c91f14
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 19:09:49 2021 +0300

    aghnet: imp code readability, docs

commit d3df15d
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 18:47:28 2021 +0300

    aghnet: fix nil pointer dereference
adguard pushed a commit that referenced this issue Dec 24, 2021
@EugeneOne1 @ainar-g
cherry-pick: 3987 Fix nil pointer dereference
7528699 
Merge in DNS/adguard-home from 3987-fix-nil-deref to master

Updates #3987.
Updates #2846.

Squashed commit of the following:

commit d653e09
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 20:08:51 2021 +0300

    all: log changes

commit c47a4ee
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 19:22:39 2021 +0300

    aghnet: fix windows tests

commit 9c91f14
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 19:09:49 2021 +0300

    aghnet: imp code readability, docs

commit d3df15d
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 18:47:28 2021 +0300

    aghnet: fix nil pointer dereference
@ainar-g ainar-g modified the milestones: v0.107.1, v0.108.0 Dec 27, 2021
adguard pushed a commit that referenced this issue Jan 21, 2022
@EugeneOne1
Pull request: 2846 cover aghnet vol.1
3f5605c 
Merge in DNS/adguard-home from 2846-cover-aghnet-vol.1 to master

Updates #2846.

Squashed commit of the following:

commit 368e75b
Author: Eugene Burkov <[email protected]>
Date:   Fri Jan 21 19:11:59 2022 +0300

    aghnet: imp tests

commit 8bb3e2a
Author: Eugene Burkov <[email protected]>
Date:   Fri Jan 21 18:27:06 2022 +0300

    aghnet: rm unused test

commit 28d8e64
Author: Eugene Burkov <[email protected]>
Date:   Fri Jan 21 18:18:22 2022 +0300

    aghnet: cover with tests
adguard pushed a commit that referenced this issue Jan 21, 2022
@EugeneOne1 @ainar-g
cherry-pick: 2846 cover aghnet vol.1
2b59273 
Merge in DNS/adguard-home from 2846-cover-aghnet-vol.1 to master

Updates #2846.

Squashed commit of the following:

commit 368e75b
Author: Eugene Burkov <[email protected]>
Date:   Fri Jan 21 19:11:59 2022 +0300

    aghnet: imp tests

commit 8bb3e2a
Author: Eugene Burkov <[email protected]>
Date:   Fri Jan 21 18:27:06 2022 +0300

    aghnet: rm unused test

commit 28d8e64
Author: Eugene Burkov <[email protected]>
Date:   Fri Jan 21 18:18:22 2022 +0300

    aghnet: cover with tests
@EugeneOne1
Copy link
Member Author

For the moment coverage is about 50%.

adguard pushed a commit that referenced this issue Mar 23, 2022
@EugeneOne1
Pull request: 2846 cover aghnet vol.2
8250556 
Merge in DNS/adguard-home from 2846-cover-aghnet-vol.2 to master

Updates #2846.
Closes #4408.

Squashed commit of the following:

commit 8d62b29
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 20:42:04 2022 +0300

    home: recover panic

commit 1d98109
Merge: ac11d75 9ce2a0f
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 20:32:05 2022 +0300

    Merge branch 'master' into 2846-cover-aghnet-vol.2

commit ac11d75
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 20:29:41 2022 +0300

    aghnet: use iotest

commit 7c923df
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 20:17:19 2022 +0300

    aghnet: cover more

commit 3bfd4d5
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 14:13:59 2022 +0300

    aghnet: cover arpdb more

commit cd5cf7b
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 13:05:35 2022 +0300

    all: rm arpdb initial refresh

commit 0fb8d9e
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 22 21:13:16 2022 +0300

    aghnet: cover arpdb
@EugeneOne1 EugeneOne1 mentioned this issue Mar 23, 2022
Closed
adguard pushed a commit that referenced this issue Mar 30, 2022
@EugeneOne1
Pull request: 2846 cover aghnet vol.3
5e71f5d 
Merge in DNS/adguard-home from 2846-cover-aghnet-vol.3 to master

Updates #2846.

Squashed commit of the following:

commit cb22987
Merge: cf995e9 f31ffcc
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 30 15:01:10 2022 +0300

    Merge branch 'master' into 2846-cover-aghnet-vol.3

commit cf995e9
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 28 18:29:50 2022 +0300

    aghnet: imp tests

commit bc225fe
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 28 18:03:06 2022 +0300

    aghnet: imp tests

commit a82eb60
Merge: f808124 0d562a7
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 28 17:39:13 2022 +0300

    Merge branch 'master' into 2846-cover-aghnet-vol.3

commit f808124
Merge: edccaa7 3603b1f
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 28 17:29:20 2022 +0300

    Merge branch 'master' into 2846-cover-aghnet-vol.3

commit edccaa7
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 28 13:53:40 2022 +0300

    aghnet: imp tests

commit 7c5028c
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 25 18:01:28 2022 +0300

    aghnet: imp code & docs

commit 7897c6b
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 25 17:11:46 2022 +0300

    aghnet: imp coverage

commit 1eef110
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 21:10:29 2022 +0300

    all: return byte slice
@EugeneOne1
Copy link
Member Author

EugeneOne1 commented Mar 30, 2022 •
edited
Loading

For the moment:

OS Coverage
Windows 79.6%
Linux 66.3%
macOS 65.1%
FreeBSD 62.8%
OpenBSD 61.9%

adguard pushed a commit that referenced this issue Mar 31, 2022
@EugeneOne1
Pull request: 2846 cover aghnet vol.4
c70f941 
Merge in DNS/adguard-home from 2846-cover-aghnet-vol.4 to master

Updates #2846.

Squashed commit of the following:

commit 576ef85
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 31 19:38:57 2022 +0300

    aghnet: imp code

commit 5b4b17f
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 31 14:58:34 2022 +0300

    aghnet: imp coverage
@EugeneOne1
Copy link
Member Author

For the moment:

OS Coverage
Windows 85.2%
macOS 68.8%
Linux 68.4%
FreeBSD 66.7%
OpenBSD 65.9%

The majority of uncovered code left in DHCP-related logic. This is what vol.5 should improve.

@ainar-g ainar-g modified the milestones: v0.108.0, v0.109.0 Apr 5, 2022
@ainar-g
Copy link
Contributor

ainar-g commented Apr 5, 2022

We have a lot of stuff to implement in this cycle, so let's move the rest of this work to the next one.

@EugeneOne1 EugeneOne1 mentioned this issue Apr 6, 2022
Closed
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2704 local resolvers vol.1
c79e60f 
Merge in DNS/adguard-home from 2704-local-addresses-vol.1 to master

Updates AdguardTeam#2704.
Updates AdguardTeam#2829.
Updates AdguardTeam#2846.

Squashed commit of the following:

commit 9a49b3d
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 22 15:39:17 2021 +0300

    aghnet: imp docs and logging

commit 74f95a2
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:56:51 2021 +0300

    all: fix friday evening mistakes

commit 0e2066b
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:51:15 2021 +0300

    all: upd testify, imp code quality

commit 8237c50
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:19:29 2021 +0300

    aghnet: imp test naming

commit 14eb1e1
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 19:41:43 2021 +0300

    aghnet: isolate windows-specific functionality

commit d461ac8
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 14:50:05 2021 +0300

    aghnet: imp code quality

commit d0ee01c
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 11:59:10 2021 +0300

    all: mv funcs to agherr, mk system resolvers getter
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 3987 Fix nil pointer dereference
02d494b 
Merge in DNS/adguard-home from 3987-fix-nil-deref to master

Updates AdguardTeam#3987.
Updates AdguardTeam#2846.

Squashed commit of the following:

commit d653e09
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 20:08:51 2021 +0300

    all: log changes

commit c47a4ee
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 19:22:39 2021 +0300

    aghnet: fix windows tests

commit 9c91f14
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 19:09:49 2021 +0300

    aghnet: imp code readability, docs

commit d3df15d
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 23 18:47:28 2021 +0300

    aghnet: fix nil pointer dereference
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2846 cover aghnet vol.1
c8ab866 
Merge in DNS/adguard-home from 2846-cover-aghnet-vol.1 to master

Updates AdguardTeam#2846.

Squashed commit of the following:

commit 368e75b
Author: Eugene Burkov <[email protected]>
Date:   Fri Jan 21 19:11:59 2022 +0300

    aghnet: imp tests

commit 8bb3e2a
Author: Eugene Burkov <[email protected]>
Date:   Fri Jan 21 18:27:06 2022 +0300

    aghnet: rm unused test

commit 28d8e64
Author: Eugene Burkov <[email protected]>
Date:   Fri Jan 21 18:18:22 2022 +0300

    aghnet: cover with tests
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2846 cover aghnet vol.2
f7dfa16 
Merge in DNS/adguard-home from 2846-cover-aghnet-vol.2 to master

Updates AdguardTeam#2846.
Closes AdguardTeam#4408.

Squashed commit of the following:

commit 8d62b29
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 20:42:04 2022 +0300

    home: recover panic

commit 1d98109
Merge: ac11d75 9ce2a0f
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 20:32:05 2022 +0300

    Merge branch 'master' into 2846-cover-aghnet-vol.2

commit ac11d75
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 20:29:41 2022 +0300

    aghnet: use iotest

commit 7c923df
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 20:17:19 2022 +0300

    aghnet: cover more

commit 3bfd4d5
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 14:13:59 2022 +0300

    aghnet: cover arpdb more

commit cd5cf7b
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 13:05:35 2022 +0300

    all: rm arpdb initial refresh

commit 0fb8d9e
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 22 21:13:16 2022 +0300

    aghnet: cover arpdb
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2846 cover aghnet vol.3
cc45f23 
Merge in DNS/adguard-home from 2846-cover-aghnet-vol.3 to master

Updates AdguardTeam#2846.

Squashed commit of the following:

commit cb22987
Merge: cf995e9 f31ffcc
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 30 15:01:10 2022 +0300

    Merge branch 'master' into 2846-cover-aghnet-vol.3

commit cf995e9
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 28 18:29:50 2022 +0300

    aghnet: imp tests

commit bc225fe
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 28 18:03:06 2022 +0300

    aghnet: imp tests

commit a82eb60
Merge: f808124 0d562a7
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 28 17:39:13 2022 +0300

    Merge branch 'master' into 2846-cover-aghnet-vol.3

commit f808124
Merge: edccaa7 3603b1f
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 28 17:29:20 2022 +0300

    Merge branch 'master' into 2846-cover-aghnet-vol.3

commit edccaa7
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 28 13:53:40 2022 +0300

    aghnet: imp tests

commit 7c5028c
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 25 18:01:28 2022 +0300

    aghnet: imp code & docs

commit 7897c6b
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 25 17:11:46 2022 +0300

    aghnet: imp coverage

commit 1eef110
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 23 21:10:29 2022 +0300

    all: return byte slice
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2846 cover aghnet vol.4
ca8a727 
Merge in DNS/adguard-home from 2846-cover-aghnet-vol.4 to master

Updates AdguardTeam#2846.

Squashed commit of the following:

commit 576ef85
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 31 19:38:57 2022 +0300

    aghnet: imp code

commit 5b4b17f
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 31 14:58:34 2022 +0300

    aghnet: imp coverage
@EugeneOne1 EugeneOne1 added the recurrent Issues about things that need to be done several times. label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
enhancement P4: Low recurrent Issues about things that need to be done several times.
Projects
None yet
Milestone
v0.109.0
Development

No branches or pull requests
2 participants
@ainar-g @EugeneOne1