Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package util #2829

Closed
ainar-g opened this issue Mar 16, 2021 · 0 comments
Closed

Remove package util #2829

ainar-g opened this issue Mar 16, 2021 · 0 comments
Assignees
Milestone

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Mar 16, 2021

Such packages are widely considered an antipattern. Ours is a mishmash of random functionality. Remove it, put functions that are needed across the project into more understandable packages.

@ainar-g ainar-g added this to the v0.106.0 milestone Mar 16, 2021
adguard pushed a commit that referenced this issue Mar 16, 2021
Merge in DNS/adguard-home from mk-aghnet to master

Updates #2829.

Squashed commit of the following:

commit 519806c
Merge: 92376c8 9736123
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 16 19:13:56 2021 +0300

    Merge branch 'master' into mk-aghnet

commit 92376c8
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 16 18:37:22 2021 +0300

    aghnet: fix linux

commit 7f36d19
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 16 18:08:30 2021 +0300

    aghnet: mv network utils from util

commit aa68c70
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 16 17:30:06 2021 +0300

    aghnet: mv ipDetector here

commit b033657
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 16 17:24:07 2021 +0300

    all: mk aghnet package, rename sysutil package
adguard pushed a commit that referenced this issue Mar 22, 2021
Merge in DNS/adguard-home from 2704-local-addresses-vol.1 to master

Updates #2704.
Updates #2829.
Updates #2846.

Squashed commit of the following:

commit 9a49b3d
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 22 15:39:17 2021 +0300

    aghnet: imp docs and logging

commit 74f95a2
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:56:51 2021 +0300

    all: fix friday evening mistakes

commit 0e2066b
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:51:15 2021 +0300

    all: upd testify, imp code quality

commit 8237c50
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:19:29 2021 +0300

    aghnet: imp test naming

commit 14eb1e1
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 19:41:43 2021 +0300

    aghnet: isolate windows-specific functionality

commit d461ac8
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 14:50:05 2021 +0300

    aghnet: imp code quality

commit d0ee01c
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 11:59:10 2021 +0300

    all: mv funcs to agherr, mk system resolvers getter
adguard pushed a commit that referenced this issue Mar 31, 2021
Merge in DNS/adguard-home from 2704-local-addresses-vol.2 to master

Updates #2704.
Updates #2829.

Squashed commit of the following:

commit 507d038
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 31 14:33:05 2021 +0300

    aghtest: fix file name

commit 8e19f99
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 31 14:06:43 2021 +0300

    aghnet: rm redundant mutexes

commit 361fa41
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 31 13:45:30 2021 +0300

    all: fix names, docs

commit 14034f4
Merge: 35e265c a72ce1c
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 31 13:38:15 2021 +0300

    Merge branch 'master' into 2704-local-addresses-vol.2

commit 35e265c
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 31 13:33:35 2021 +0300

    aghnet: imp naming

commit 7a7edac
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 30 20:59:54 2021 +0300

    changelog: oops, nope yet

commit d26a5d2
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 30 20:55:53 2021 +0300

    all: some renaming for the glory of semantics

commit 9937fa6
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 29 15:34:42 2021 +0300

    all: log changes

commit d8d9e6d
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 26 18:32:23 2021 +0300

    all: imp localresolver, imp cutting off own addresses

commit 344140d
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 26 14:53:33 2021 +0300

    all: imp code quality

commit 1c5c0ba
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 25 20:44:08 2021 +0300

    all: fix go.mod

commit 0b9fb3c
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 25 20:38:51 2021 +0300

    all: add error handling

commit a7a2e51
Merge: c13be63 27f4f05
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 25 19:48:36 2021 +0300

    Merge branch 'master' into 2704-local-addresses-vol.2

commit c13be63
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 25 18:52:28 2021 +0300

    all: cover rdns with tests, imp aghnet functionality

commit 48bed90
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 24 20:18:07 2021 +0300

    home: make rdns great again

commit 1dbacfc
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 24 16:07:52 2021 +0300

    all: imp external client restriction

commit 1208a31
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 22 15:26:45 2021 +0300

    all: finish local ptr processor

commit c8827fc
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 2 13:41:22 2021 +0300

    all: imp ipdetector, add local ptr processor
adguard pushed a commit that referenced this issue Apr 7, 2021
Merge in DNS/adguard-home from 2704-local-addresses-vol.3 to master

Updates #2704.
Updates #2829.
Updates #2928.

Squashed commit of the following:

commit 8c42355
Author: Eugene Burkov <[email protected]>
Date:   Wed Apr 7 18:07:41 2021 +0300

    dnsforward: rm errors pkg

commit 7594a21
Merge: 830b083 908452f
Author: Eugene Burkov <[email protected]>
Date:   Wed Apr 7 18:00:03 2021 +0300

    Merge branch 'master' into 2704-local-addresses-vol.3

commit 830b083
Author: Eugene Burkov <[email protected]>
Date:   Wed Apr 7 17:47:51 2021 +0300

    dnsforward: reduce local upstream timeout

commit 493e81d
Author: Ildar Kamalov <[email protected]>
Date:   Tue Apr 6 19:11:00 2021 +0300

    client: private_upstream test

commit a0194ac
Author: Eugene Burkov <[email protected]>
Date:   Tue Apr 6 18:36:23 2021 +0300

    all: expand api, fix conflicts

commit 0f4e068
Merge: 89cf93a 8746005
Author: Eugene Burkov <[email protected]>
Date:   Tue Apr 6 18:35:04 2021 +0300

    Merge branch 'master' into 2704-local-addresses-vol.3

commit 89cf93a
Author: Ildar Kamalov <[email protected]>
Date:   Tue Apr 6 18:02:40 2021 +0300

    client: add local ptr upstreams to upstream test

commit e6dd869
Author: Ildar Kamalov <[email protected]>
Date:   Tue Apr 6 15:24:22 2021 +0300

    client: add private DNS form

commit b858057
Author: Eugene Burkov <[email protected]>
Date:   Tue Apr 6 13:05:28 2021 +0300

    aghstrings: mk cloning correct

commit 8009ba6
Author: Eugene Burkov <[email protected]>
Date:   Tue Apr 6 12:37:46 2021 +0300

    aghstrings: fix lil bug

commit 0dd19f2
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 5 20:45:01 2021 +0300

    all: log changes

commit eb5558d
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 5 20:18:53 2021 +0300

    dnsforward: keep the style

commit d6d5fcb
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 5 20:02:52 2021 +0300

    dnsforward: disable redundant filtering for local ptr

commit 4f864c3
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 5 17:53:17 2021 +0300

    dnsforward: imp tests

commit 7848e6f
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 5 14:52:12 2021 +0300

    all: imp code

commit 19ac306
Author: Eugene Burkov <[email protected]>
Date:   Sun Apr 4 16:28:05 2021 +0300

    all: mv more logic to aghstrings

commit fac892e
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 2 20:23:23 2021 +0300

    dnsforward: use filepath

commit 05a3aee
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 2 20:17:54 2021 +0300

    aghstrings: introduce the pkg

commit f24e1b6
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 2 20:01:23 2021 +0300

    all: imp code

commit 0217a0e
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 2 18:04:13 2021 +0300

    openapi: log changes

... and 3 more commits
adguard pushed a commit that referenced this issue Apr 8, 2021
Updates #2829.

Squashed commit of the following:

commit a284a26
Author: Ainar Garipov <[email protected]>
Date:   Thu Apr 8 20:34:20 2021 +0300

    aghos: fix darwin

commit 9dbd42d
Author: Ainar Garipov <[email protected]>
Date:   Thu Apr 8 20:11:56 2021 +0300

    all: mv IsOpenWrt
adguard pushed a commit that referenced this issue Apr 12, 2021
Merge in DNS/adguard-home from 1947-hosts-opt to master

Updates #1947.
Updates #2829.

Squashed commit of the following:

commit d09285c
Merge: cff8c4c 7c6557b
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 18:23:20 2021 +0300

    Merge branch 'master' into 1947-hosts-opt

commit cff8c4c
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 17:46:19 2021 +0300

    home: fix help

commit 1fa01d5
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 17:40:48 2021 +0300

    home: fix option order

commit 9d83cb6
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 17:28:30 2021 +0300

    aghnet: add important todo

commit 7f1386f
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 17:17:17 2021 +0300

    all: correct naming

commit cbe2b2e
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 15:55:46 2021 +0300

    all: mv functionality from util

commit e82ad53
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 15:41:35 2021 +0300

    home: imp code, docs

commit 9058977
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 15:02:34 2021 +0300

    home: add an option to disable autohosts
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from mk-aghnet to master

Updates AdguardTeam#2829.

Squashed commit of the following:

commit 519806c
Merge: 92376c8 9736123
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 16 19:13:56 2021 +0300

    Merge branch 'master' into mk-aghnet

commit 92376c8
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 16 18:37:22 2021 +0300

    aghnet: fix linux

commit 7f36d19
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 16 18:08:30 2021 +0300

    aghnet: mv network utils from util

commit aa68c70
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 16 17:30:06 2021 +0300

    aghnet: mv ipDetector here

commit b033657
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 16 17:24:07 2021 +0300

    all: mk aghnet package, rename sysutil package
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 2704-local-addresses-vol.1 to master

Updates AdguardTeam#2704.
Updates AdguardTeam#2829.
Updates AdguardTeam#2846.

Squashed commit of the following:

commit 9a49b3d
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 22 15:39:17 2021 +0300

    aghnet: imp docs and logging

commit 74f95a2
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:56:51 2021 +0300

    all: fix friday evening mistakes

commit 0e2066b
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:51:15 2021 +0300

    all: upd testify, imp code quality

commit 8237c50
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 20:19:29 2021 +0300

    aghnet: imp test naming

commit 14eb1e1
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 19:41:43 2021 +0300

    aghnet: isolate windows-specific functionality

commit d461ac8
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 14:50:05 2021 +0300

    aghnet: imp code quality

commit d0ee01c
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 19 11:59:10 2021 +0300

    all: mv funcs to agherr, mk system resolvers getter
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 2704-local-addresses-vol.2 to master

Updates AdguardTeam#2704.
Updates AdguardTeam#2829.

Squashed commit of the following:

commit 507d038
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 31 14:33:05 2021 +0300

    aghtest: fix file name

commit 8e19f99
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 31 14:06:43 2021 +0300

    aghnet: rm redundant mutexes

commit 361fa41
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 31 13:45:30 2021 +0300

    all: fix names, docs

commit 14034f4
Merge: 35e265c a72ce1c
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 31 13:38:15 2021 +0300

    Merge branch 'master' into 2704-local-addresses-vol.2

commit 35e265c
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 31 13:33:35 2021 +0300

    aghnet: imp naming

commit 7a7edac
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 30 20:59:54 2021 +0300

    changelog: oops, nope yet

commit d26a5d2
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 30 20:55:53 2021 +0300

    all: some renaming for the glory of semantics

commit 9937fa6
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 29 15:34:42 2021 +0300

    all: log changes

commit d8d9e6d
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 26 18:32:23 2021 +0300

    all: imp localresolver, imp cutting off own addresses

commit 344140d
Author: Eugene Burkov <[email protected]>
Date:   Fri Mar 26 14:53:33 2021 +0300

    all: imp code quality

commit 1c5c0ba
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 25 20:44:08 2021 +0300

    all: fix go.mod

commit 0b9fb3c
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 25 20:38:51 2021 +0300

    all: add error handling

commit a7a2e51
Merge: c13be63 27f4f05
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 25 19:48:36 2021 +0300

    Merge branch 'master' into 2704-local-addresses-vol.2

commit c13be63
Author: Eugene Burkov <[email protected]>
Date:   Thu Mar 25 18:52:28 2021 +0300

    all: cover rdns with tests, imp aghnet functionality

commit 48bed90
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 24 20:18:07 2021 +0300

    home: make rdns great again

commit 1dbacfc
Author: Eugene Burkov <[email protected]>
Date:   Wed Mar 24 16:07:52 2021 +0300

    all: imp external client restriction

commit 1208a31
Author: Eugene Burkov <[email protected]>
Date:   Mon Mar 22 15:26:45 2021 +0300

    all: finish local ptr processor

commit c8827fc
Author: Eugene Burkov <[email protected]>
Date:   Tue Mar 2 13:41:22 2021 +0300

    all: imp ipdetector, add local ptr processor
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 2704-local-addresses-vol.3 to master

Updates AdguardTeam#2704.
Updates AdguardTeam#2829.
Updates AdguardTeam#2928.

Squashed commit of the following:

commit 8c42355
Author: Eugene Burkov <[email protected]>
Date:   Wed Apr 7 18:07:41 2021 +0300

    dnsforward: rm errors pkg

commit 7594a21
Merge: 830b083 908452f
Author: Eugene Burkov <[email protected]>
Date:   Wed Apr 7 18:00:03 2021 +0300

    Merge branch 'master' into 2704-local-addresses-vol.3

commit 830b083
Author: Eugene Burkov <[email protected]>
Date:   Wed Apr 7 17:47:51 2021 +0300

    dnsforward: reduce local upstream timeout

commit 493e81d
Author: Ildar Kamalov <[email protected]>
Date:   Tue Apr 6 19:11:00 2021 +0300

    client: private_upstream test

commit a0194ac
Author: Eugene Burkov <[email protected]>
Date:   Tue Apr 6 18:36:23 2021 +0300

    all: expand api, fix conflicts

commit 0f4e068
Merge: 89cf93a 8746005
Author: Eugene Burkov <[email protected]>
Date:   Tue Apr 6 18:35:04 2021 +0300

    Merge branch 'master' into 2704-local-addresses-vol.3

commit 89cf93a
Author: Ildar Kamalov <[email protected]>
Date:   Tue Apr 6 18:02:40 2021 +0300

    client: add local ptr upstreams to upstream test

commit e6dd869
Author: Ildar Kamalov <[email protected]>
Date:   Tue Apr 6 15:24:22 2021 +0300

    client: add private DNS form

commit b858057
Author: Eugene Burkov <[email protected]>
Date:   Tue Apr 6 13:05:28 2021 +0300

    aghstrings: mk cloning correct

commit 8009ba6
Author: Eugene Burkov <[email protected]>
Date:   Tue Apr 6 12:37:46 2021 +0300

    aghstrings: fix lil bug

commit 0dd19f2
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 5 20:45:01 2021 +0300

    all: log changes

commit eb5558d
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 5 20:18:53 2021 +0300

    dnsforward: keep the style

commit d6d5fcb
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 5 20:02:52 2021 +0300

    dnsforward: disable redundant filtering for local ptr

commit 4f864c3
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 5 17:53:17 2021 +0300

    dnsforward: imp tests

commit 7848e6f
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 5 14:52:12 2021 +0300

    all: imp code

commit 19ac306
Author: Eugene Burkov <[email protected]>
Date:   Sun Apr 4 16:28:05 2021 +0300

    all: mv more logic to aghstrings

commit fac892e
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 2 20:23:23 2021 +0300

    dnsforward: use filepath

commit 05a3aee
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 2 20:17:54 2021 +0300

    aghstrings: introduce the pkg

commit f24e1b6
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 2 20:01:23 2021 +0300

    all: imp code

commit 0217a0e
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 2 18:04:13 2021 +0300

    openapi: log changes

... and 3 more commits
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#2829.

Squashed commit of the following:

commit a284a26
Author: Ainar Garipov <[email protected]>
Date:   Thu Apr 8 20:34:20 2021 +0300

    aghos: fix darwin

commit 9dbd42d
Author: Ainar Garipov <[email protected]>
Date:   Thu Apr 8 20:11:56 2021 +0300

    all: mv IsOpenWrt
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 1947-hosts-opt to master

Updates AdguardTeam#1947.
Updates AdguardTeam#2829.

Squashed commit of the following:

commit d09285c
Merge: cff8c4c 7c6557b
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 18:23:20 2021 +0300

    Merge branch 'master' into 1947-hosts-opt

commit cff8c4c
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 17:46:19 2021 +0300

    home: fix help

commit 1fa01d5
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 17:40:48 2021 +0300

    home: fix option order

commit 9d83cb6
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 17:28:30 2021 +0300

    aghnet: add important todo

commit 7f1386f
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 17:17:17 2021 +0300

    all: correct naming

commit cbe2b2e
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 15:55:46 2021 +0300

    all: mv functionality from util

commit e82ad53
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 15:41:35 2021 +0300

    home: imp code, docs

commit 9058977
Author: Eugene Burkov <[email protected]>
Date:   Mon Apr 12 15:02:34 2021 +0300

    home: add an option to disable autohosts
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 2829-finally to master

Closes AdguardTeam#2829.

Squashed commit of the following:

commit 22b287d
Author: Eugene Burkov <[email protected]>
Date:   Wed Apr 21 18:39:54 2021 +0300

    util: rm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants