Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set device tags on device create/details screens #366

Merged
merged 49 commits into from
Mar 4, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Mar 2, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI requested a review from a team as a code owner March 2, 2022 10:10
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #366 (61bd865) into main (4334d20) will increase coverage by 0.18%.
The diff coverage is 60.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   46.16%   46.35%   +0.18%     
==========================================
  Files         102      103       +1     
  Lines        3041     3126      +85     
==========================================
+ Hits         1404     1449      +45     
- Misses       1637     1677      +40     
Impacted Files Coverage Δ
...Portal/Client/Pages/Devices/CreateDevicePage.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 0.00% <0.00%> (ø)
...lient/Pages/Devices/LoRaWAN/CreateLoraDevice.razor 0.00% <0.00%> (ø)
.../Client/Pages/Devices/LoRaWAN/EditLoraDevice.razor 0.00% <0.00%> (ø)
....Portal/Client/Pages/Settings/DeviceTagsPage.razor 0.00% <ø> (ø)
...Portal/Client/Validators/DeviceDetailsValidator.cs 0.00% <0.00%> (ø)
...al/Client/Validators/LoRaDeviceDetailsValidator.cs 0.00% <0.00%> (ø)
...ureIoTHub.Portal/Server/Mappers/DeviceTagMapper.cs 100.00% <ø> (ø)
src/AzureIoTHub.Portal/Server/Startup.cs 1.98% <0.00%> (-0.02%) ⬇️
...THub.Portal/Shared/Models/v1.0/Device/DeviceTag.cs 100.00% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4334d20...61bd865. Read the comment docs.

kbeaugrand and others added 2 commits March 4, 2022 09:29
* Fix #308 - Remove useless pages in table queries

* Add some unit test to increase code coverage
@audserraCGI audserraCGI changed the title WIP : Set device tags on device create/details screens Set device tags on device create/details screens Mar 4, 2022
@audserraCGI audserraCGI requested review from kbeaugrand and Sben65 March 4, 2022 10:29
@Sben65 Sben65 dismissed kbeaugrand’s stale review March 4, 2022 10:36

this review is outdated

@audserraCGI audserraCGI merged commit b1e1f0f into main Mar 4, 2022
@audserraCGI audserraCGI deleted the 236_set_tag_on_devices branch March 4, 2022 10:41
@github-actions github-actions bot mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants