-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Snyk scanning & monitoring #974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes but you are on the right track 😄
For testing purposes, I would switch the condition around the branch, to run run a snyk monitor, and then go here: This way you can test it without merging to main. |
Diff: CircleCI-Public/circleci-config@182164c...c469d9e Includes: - Improvements to Go, Python, Node & Ruby - Added support for Rust & PHP
* update goreleaser version * install goreleaaser with apt * fix version * make apt quieter * fix dockerfiles * increase build executor resource class * remove cache
* deps: remove replace directive for etcd from go.mod * add a few miising dependencies to go.sum
549d4c4
to
4e25bb4
Compare
Messed up during git rebase 🤦🏾♂️ . I'll open a new PR with these changes. |
Closing this PR in favor of #978 |
Checklist
=========
Internal Checklist
Changes
=======
vulnerability-scan
job to the CircleCI config, to run Snyk scansRationale
=========
The Snyk scans should only create a snapshot during CI when the changes are on the
main
branch.Considerations
==============
Why you made some of the technical decisions that you made, especially if the
reasoning is not immediately obvious
Screenshots
============
Before
Image or [gif](https://giphy.com/apps/giphycapture)After
Image or gif where change can be clearly seenHere are some helpful tips you can follow when submitting a pull request:
main
.make build
in the repository root.make test
).--debug
flag is often helpful for debugging HTTP client requests and responses.make lint
). Note: This requires Docker to run inside a local job.