Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapply reverted changes #985

Merged
merged 4 commits into from
Aug 7, 2023
Merged

Reapply reverted changes #985

merged 4 commits into from
Aug 7, 2023

Conversation

JulesFaucherre
Copy link
Contributor

This PR only aims at reapplying some of the changes that were reverted in this PR

It reintroduces:

  • the bump of the circleci-config version
  • the fix to not create a license file on initializing a private orb
  • the build & release of the darwin/arm64 binary
  • the removal of replace directive

It does not reintroduce:

  • the telemetry: being the source of the bug, there is still a decision to be taken on how to address it

polymeris and others added 4 commits August 7, 2023 15:23
@polymeris @JulesFaucherre
feat: Bump the circleci-config version
ed59493 
Diff: CircleCI-Public/circleci-config@182164c...c469d9e

Includes:
- Improvements to Go, Python, Node & Ruby
- Added support for Rust & PHP
@loderunner @JulesFaucherre
fix: don't create license file when initializing private orb (#962)
d6df28a
@loderunner @JulesFaucherre
feat: build & release darwin/arm64 binary (#961)
92911e3 
* update goreleaser version

* install goreleaaser with apt

* fix version

* make apt quieter

* fix dockerfiles

* increase build executor resource class

* remove cache
@loderunner @JulesFaucherre
deps: remove replace directive for etcd from go.mod (#966)
6e6f8f5 
* deps: remove replace directive for etcd from go.mod

* add a few miising dependencies to go.sum
@JulesFaucherre JulesFaucherre requested review from a team as code owners August 7, 2023 13:31
@JulesFaucherre JulesFaucherre merged commit 4afe3de into develop Aug 7, 2023
@JulesFaucherre JulesFaucherre deleted the reapply-reverted-changes branch August 7, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loderunner loderunner loderunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulesFaucherre @loderunner @polymeris