Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some vehicles fire only one projectile for its canister shot #2

Closed
cmbasnett opened this issue Jul 6, 2014 · 2 comments
Closed

Some vehicles fire only one projectile for its canister shot #2

cmbasnett opened this issue Jul 6, 2014 · 2 comments

Comments

@cmbasnett
Copy link
Member

Originally reported by: Colin Basnett (Bitbucket: cmbasnett, GitHub: cmbasnett)


Steps to Reproduce

  1. Enter any of the affected vehicles (listed below)
  2. Switch projectile type to Canister.
  3. Fire the cannon.

Results

Only one projectile fires in the following vehicles:

  • M8 Greyhound
  • M5 Stuart
  • Panzer III Ausf. N

Expected Results

A large amount of projectiles are fired.


@cmbasnett
Copy link
Member Author

Original comment by Colin Basnett (Bitbucket: cmbasnett, GitHub: cmbasnett):


Fixed in revision 2b8eae5.

@cmbasnett
Copy link
Member Author

Original comment by Colin Basnett (Bitbucket: cmbasnett, GitHub: cmbasnett):


Fixed in revision 8d80ff6.

AndrewTheel added a commit that referenced this issue Mar 14, 2018
 1) Fix for #937 (tested in MP and fix confirmed)
 2) Added prevention for server to be running TakeDamage() on already dead vehicles (this should hopefully not cause issues and optimize things)
 3) Added prevention for server to be calling SetEngine() if the engine is already dead and burning (not really needed because of #2, but left in just in case)

Hopefully no issues arise because of #2 and #3
AndrewTheel added a commit that referenced this issue May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant