Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VehicleSay messages can be sent with no content #3

Closed
cmbasnett opened this issue Jul 7, 2014 · 1 comment
Closed

VehicleSay messages can be sent with no content #3

cmbasnett opened this issue Jul 7, 2014 · 1 comment
Labels
bug vehicles

Comments

@cmbasnett
Copy link
Member

Originally reported by: Colin Basnett (Bitbucket: cmbasnett, GitHub: cmbasnett)

Steps to Reproduce

  1. Enter any vehicle.
  2. Press the VehicleSay key (default U)
  3. Press Enter.

Results

An empty VehicleSay message is sent.

Expected Results

No VehicleSay message is sent.
@cmbasnett
Copy link
Member Author

Original comment by Andrew Theel (Bitbucket: AndrewTheel, GitHub: AndrewTheel):

Fixed in commit 079d2dd

@AndrewTheel AndrewTheel mentioned this issue Jan 12, 2017
Closed
AndrewTheel added a commit that referenced this issue Mar 14, 2018
@AndrewTheel
Some disguised big changes here:
3060b6c 
 1) Fix for #937 (tested in MP and fix confirmed)
 2) Added prevention for server to be running TakeDamage() on already dead vehicles (this should hopefully not cause issues and optimize things)
 3) Added prevention for server to be calling SetEngine() if the engine is already dead and burning (not really needed because of #2, but left in just in case)

Hopefully no issues arise because of #2 and #3
AndrewTheel added a commit that referenced this issue May 21, 2019
@AndrewTheel
Update #3
b403d5b
cmbasnett added a commit that referenced this issue Aug 29, 2021
@cmbasnett
Clean up pass #3
e22059d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug vehicles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmbasnett