Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No engine burning effect on clients for vehicles with engine turned off #937

Closed
AndrewTheel opened this issue Mar 14, 2018 · 1 comment
Closed

No engine burning effect on clients for vehicles with engine turned off #937

AndrewTheel opened this issue Mar 14, 2018 · 1 comment
Assignees
@AndrewTheel
Labels
bug vehicles

Comments

@AndrewTheel
Copy link
Contributor

I noticed that vehicles with engine turned off would not display engine fire when they take damage. Though this may have been a desired effect, it makes no sense from the player's perspective and definitely feels like a bug.

Repo steps:

  1. On server have a client drive a truck to random location and turn off engine
  2. Shoot the truck in the engine until it blows up, it won't ever display the engine fire

The problem:
There is nothing to tell the client to display the fire effects when the engine is turned off. I think a very simple solution is to have a check in PostNetReceive() to check if the fire effect is not displaying and if the engine health is <= 0.
@AndrewTheel AndrewTheel self-assigned this Mar 14, 2018
AndrewTheel added a commit that referenced this issue Mar 14, 2018
@AndrewTheel
Some disguised big changes here:
3060b6c 
 1) Fix for #937 (tested in MP and fix confirmed)
 2) Added prevention for server to be running TakeDamage() on already dead vehicles (this should hopefully not cause issues and optimize things)
 3) Added prevention for server to be calling SetEngine() if the engine is already dead and burning (not really needed because of #2, but left in just in case)

Hopefully no issues arise because of #2 and #3
@AndrewTheel
Copy link
Contributor Author

Should be resolved in: 3060b6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewTheel AndrewTheel

Labels
bug vehicles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndrewTheel