-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kpt Deployer applyDir implementation and tests #4691
Kpt Deployer applyDir implementation and tests #4691
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4691 +/- ##
==========================================
+ Coverage 73.18% 73.21% +0.03%
==========================================
Files 340 340
Lines 13372 13398 +26
==========================================
+ Hits 9786 9810 +24
- Misses 2979 2980 +1
- Partials 607 608 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM 👍🏽 For follow up work let's maybe mention that we plan to move away from consuming kpt as a CLI in the future
Related: #3904
Description
This is the implementation and tests for the getApplyDir() method of the kpt deployer. This method resolves the package to deploy to the cluster. Users have the option to specify the package themselves in the skaffold config. However if left unspecified, the method will create a hidden directory called .kpt-hydrated and run
kpt live init
if necessary to create the required template resource (runningkpt live init
is not done for user specified applyDir even if the template resource is not present).User facing changes
Users will have the ability to specify their own applyDir in skaffold.yaml.