Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kpt Deployer applyDir implementation and tests #4691

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Kpt Deployer applyDir implementation and tests #4691

merged 2 commits into from
Aug 18, 2020

Conversation

felixtran39
Copy link
Contributor

@felixtran39 felixtran39 commented Aug 18, 2020

Related: #3904

Description
This is the implementation and tests for the getApplyDir() method of the kpt deployer. This method resolves the package to deploy to the cluster. Users have the option to specify the package themselves in the skaffold config. However if left unspecified, the method will create a hidden directory called .kpt-hydrated and run kpt live init if necessary to create the required template resource (running kpt live init is not done for user specified applyDir even if the template resource is not present).

User facing changes
Users will have the ability to specify their own applyDir in skaffold.yaml.

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #4691 into master will increase coverage by 0.03%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4691      +/-   ##
==========================================
+ Coverage   73.18%   73.21%   +0.03%     
==========================================
  Files         340      340              
  Lines       13372    13398      +26     
==========================================
+ Hits         9786     9810      +24     
- Misses       2979     2980       +1     
- Partials      607      608       +1     
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
pkg/skaffold/deploy/kpt.go 94.44% <92.59%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72560a3...c5501e8. Read the comment docs.

@MarlonGamez MarlonGamez added the kokoro:run runs the kokoro jobs on a PR label Aug 18, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Aug 18, 2020
@MarlonGamez MarlonGamez added the kokoro:run runs the kokoro jobs on a PR label Aug 18, 2020
@felixtran39 felixtran39 added kokoro:run runs the kokoro jobs on a PR and removed kokoro:run runs the kokoro jobs on a PR labels Aug 18, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Aug 18, 2020
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍🏽 For follow up work let's maybe mention that we plan to move away from consuming kpt as a CLI in the future

pkg/skaffold/deploy/kpt.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants