Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vietnamese language #14

Closed
haunt98 opened this issue Jan 15, 2020 · 6 comments
Closed

Add Vietnamese language #14

haunt98 opened this issue Jan 15, 2020 · 6 comments
Labels
unicode request Request for adding more symbols

Comments

@haunt98
Copy link
Contributor

haunt98 commented Jan 15, 2020

I don't see Vietnamese language in 143 languages supported.
@philippnurullin philippnurullin added the enhancement New feature or request label Jan 17, 2020
@philippnurullin philippnurullin mentioned this issue Jan 31, 2020
Closed
@thang-nm
Copy link

thang-nm commented Feb 8, 2020 •
edited
Loading

@philippnurullin Do you have any plans for supporting Vietnamese?

@philippnurullin
Copy link
Member

@thang-nm Yes, but can't say the exact date.

@philippnurullin philippnurullin added unicode request Request for adding more symbols and removed enhancement New feature or request labels Mar 16, 2020
@dinhquochan
Copy link

Hey @philippnurullin can I contribute Vietnamese characters to VFC? I open *.vfc and see two masters is Regular & ExtraBold, just add glyphs like:

image

  • a á à ả ã ạ ă ắ ằ ẵ ẳ ặ â ấ ầ ẫ ẩ ậ
  • A Á À Ả Ã Ạ Ă Ắ Ằ Ẵ Ẳ Ặ Â Ấ Ầ Ẫ Ẩ Ậ
  • i í ì ỉ ĩ ị
  • I Í Ì Ỉ Ĩ
  • u ú ù ũ ủ ụ ư ứ ừ ữ ử ự
  • U Ú Ù Ũ Ủ Ụ Ư Ứ Ừ Ữ Ử Ự
  • o ó ò õ ỏ ọ ô ố ồ ỗ ổ ộ ơ ớ ờ ỡ ở ợ
  • O Ó Ò Õ Ỏ Ọ Ô Ố Ồ Ỗ Ổ Ộ Ơ Ớ Ờ Ỡ Ở Ợ
  • y ý ỳ ỷ ỹ ỵ
  • Y Ý Ỳ Ỷ Ỹ Ỵ

Src: https://vietnamesetypography.com/

@philippnurullin
Copy link
Member

Hi @dinhquochan As you spotted i started to add the Vietnamese diacritics as an experiment. Talking about uni0309 hookabovecomb and others. The original idea was to include the Vietnamese in v1.0.5 release. But after experimenting i got the feeling that it is became too cluttered. Especially in ExtraBold. So to properly implement it, we need to make a whole diacritics revision. And i'm currently in process of that.

As i'm really thankful for you will to contribute but i already working on this part, so it will be not wise to stopping. Still can't say the exact release date. Just know it won't be in in the 1.0.6.

I'll be really grateful if you look at the results & thank you for the link.

@philippnurullin philippnurullin mentioned this issue Apr 15, 2020
Closed
philippnurullin added a commit that referenced this issue Apr 29, 2020
@philippnurullin
v1.0.6
4dd35ad 
Major changes
— Fixed problems with rendering of Powerline symbols #189
— Added support of Vietnamese language #14 #209
— All diacritics redone. Corrected a bunch of problems of placing & more balanced mass.
— Added DesignSpace+UFO source files. Just converted & dumped as they are, for now. There are issues with Masters compatibility. Tested in Glyphs app.

Other fixes
— Fixed construction of † ‡ ∏ ∐  #205 #206
— Added exclusion in /* ligature #88
— Refactored ß
— ~= ligature removed #204
— Added >-> ligature #194
— Added u0336 Long stroke overlay #190
— Added ligature //= #185
— Corrected contour of the arrows in ligatures #196

Known issues
— In Medium weights the height of [ ] { } decreased by one pixel in 12px, 13px sizes. This is a hinting bug.
@philippnurullin
Copy link
Member

Hey! How is the added Vietnamese support in 1.0.6. Do you have any difficulties with it? If you stumble upon some problem feel free to open new issues.

@dinhquochan
Copy link

Yay, thank @philippnurullin

@haunt98 haunt98 mentioned this issue Jul 19, 2023
Open
@haunt98 haunt98 mentioned this issue Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unicode request Request for adding more symbols
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@haunt98 @thang-nm @dinhquochan @philippnurullin