Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ligatures in a glob pattern look inconsistent #88

Closed
hudochenkov opened this issue Jan 23, 2020 · 5 comments
Closed

Ligatures in a glob pattern look inconsistent #88

hudochenkov opened this issue Jan 23, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@hudochenkov
Copy link

Thank for a very nice font!

I noticed in glob pattern ligatures for comments make it look funny:

Screen Shot 2020-01-23 at 10 59 57

src/**.*    **/*.js    src/**/*.js

Hope it's possible to fix.

Font size 13px in VSCode 1.41.1 on macOS 10.14.6.
@philippnurullin
Copy link
Member

@hudochenkov Yes it is. In v 1.0.3

@philippnurullin philippnurullin added the bug Something isn't working label Jan 27, 2020
@cipriancraciun cipriancraciun mentioned this issue Feb 5, 2020
Closed
@philippnurullin philippnurullin mentioned this issue Feb 7, 2020
Closed
philippnurullin added a commit that referenced this issue Feb 7, 2020
@philippnurullin
v.1.0.3
a17943e 
— Added support of Box Drawings 159 symbols #84 #55
— Added ligature `<--` #95
— Removed the `\/` & `/\` ligatures #65 #76 #78 #83
— Corrected behaviour of ligatures in a glob pattern #88
— Changed the `$` & dependent glyphs #110
— Added no-break space #94
— Corrected unexpected `>=` ligature usage in `>=<` sequence 
— Refactored `w`, `W`, `m`, `M`
— Slightly tuned ascenders & descenders
— Added support of Mongolian language #81
— Better placement of the dot in 0 #104
— Reorganised family names #122
philippnurullin added a commit that referenced this issue Feb 7, 2020
@philippnurullin
v.1.0.3
eeed8f1 
— Added support of Box Drawings 159 symbols #84 #55
— Added ligature `<--` #95
— Removed the `\/` & `/\` ligatures #65 #76 #78 #83
— Corrected behaviour of ligatures in a glob pattern #88
— Changed the `$` & dependent glyphs #110
— Added no-break space #94
— Corrected unexpected `>=` ligature usage in `>=<` sequence 
— Refactored `w`, `W`, `m`, `M`
— Slightly tuned ascenders & descenders
— Added support of Mongolian language #81
— Better placement of the dot in 0 #104
— Reorganised family names #122
— Updated download link in README.md
@philippnurullin philippnurullin mentioned this issue Apr 9, 2020
Closed
@trygveaa
Copy link

Hm, there are still some issues here, for instance src/*.* looks weird. Maybe the /* ligature should only apply if it has whitespace on both sides?

image

@philippnurullin
Copy link
Member

@trygveaa Thanks for bringing that up. Will fix this in next update.

philippnurullin added a commit that referenced this issue Apr 29, 2020
@philippnurullin
v1.0.6
4dd35ad 
Major changes
— Fixed problems with rendering of Powerline symbols #189
— Added support of Vietnamese language #14 #209
— All diacritics redone. Corrected a bunch of problems of placing & more balanced mass.
— Added DesignSpace+UFO source files. Just converted & dumped as they are, for now. There are issues with Masters compatibility. Tested in Glyphs app.

Other fixes
— Fixed construction of † ‡ ∏ ∐  #205 #206
— Added exclusion in /* ligature #88
— Refactored ß
— ~= ligature removed #204
— Added >-> ligature #194
— Added u0336 Long stroke overlay #190
— Added ligature //= #185
— Corrected contour of the arrows in ligatures #196

Known issues
— In Medium weights the height of [ ] { } decreased by one pixel in 12px, 13px sizes. This is a hinting bug.
@trygveaa
Copy link

trygveaa commented Apr 30, 2020 •
edited
Loading

While /*.* looks fine now, it's still an issue if you have characters between, like this:
image

A similar issue exists with */ in regexes:
image
vs.
image

Or this:
image

Edit: One more:
image

@philippnurullin
Copy link
Member

Thanks for the examples. Update the ligatures in next version.

philippnurullin added a commit that referenced this issue Jul 10, 2020
@philippnurullin
Updated to v2.000
598943b 
— Added 3 lighter weights with matching italics #1
SemiLight — Special for the dark background. It’s a slightly more thin version of Regular.
Light — Will perform best on HiDpi in more big sizes.
ExtraLight — If you want to go even thinner. Recommended for presentation mode.
— Added Variable format for more precise weight tuning.
— Project migrated from FontLab to Glyphs. Source in UFO provided.
— *ML comment ligatures are vertically misaligned #77
— Ligatures in a glob pattern look inconsistent #88
— Zero - hinting the dot #104
— Big space above text in OneNote #210
— Corrected hinting #218 #235 #239 #252
— Monospaced detection errors  #227 #230
— Wrong interpretation in "<||> |>" #234
— Reworked % ‰ #236
— Missing some Powerline symbols #240
— Disable `>-` ligature when followed by `<` (`>-<`) #251
— Add the Latin Capital Letter Sharp S (U+1E9E) #262
— Added superior & inferior numbers ⁰¹²³⁴⁵⁶⁷⁸⁹₀₁₂₃₄₅₆₇₈₉
— Fine tuning of capital, ascender & descender metrics
— Raised the bar in `f` to work better in context of the line
— More spacing tuning in arrow ligatures
— Corrections in  -<  -<<  <— <!—
— More pronounced bar in Ħ Ŧ ћ ħ đ ŧ
— Correct u+02C9 placement
— Corrected placement of Ogonek in Uogonek
— Corrections in Vietnamese diacritics
@philippnurullin philippnurullin mentioned this issue Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trygveaa @hudochenkov @philippnurullin