Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to change ligature for ~= and add ligature for =~= #204

Closed
thebertster opened this issue Apr 9, 2020 · 3 comments
Closed

Request to change ligature for ~= and add ligature for =~= #204

thebertster opened this issue Apr 9, 2020 · 3 comments
Labels
unicode request Request for adding more symbols

Comments

@thebertster
Copy link

Currently the ligature for ~= is rendered as an "approximately equal to" glyph.

In Lua and Matlab, ~= means "not equal to" - using the approximately equals sign both looks strange and is prone to mis-reading, especially when scanning through code quickly.

I couldn't find any language where "~=" actually means "approximately equal to", so it would seem sensible to change this ligature to the "not equals" glyph (same as !=).

Just to note that the latest version of Fira Code has (finally) made this change after it was requested quite some time ago.

Also to note that in Perl, "=~=" actually does mean "approximately equal" so it would also make sense for this ligature to be added as the "approximately equal to" glyph.
@philippnurullin
Copy link
Member

Nice, thanks for bringing that up. Will fix soon.

@philippnurullin philippnurullin added the unicode request Request for adding more symbols label Apr 10, 2020
@philippnurullin
Copy link
Member

~= will be removed the in the next update.

On the =~= need to think more. Found the discussion in Fira Code community:
tonsky/FiraCode#407
tonsky/FiraCode#143

philippnurullin added a commit that referenced this issue Apr 29, 2020
@philippnurullin
v1.0.6
4dd35ad 
Major changes
— Fixed problems with rendering of Powerline symbols #189
— Added support of Vietnamese language #14 #209
— All diacritics redone. Corrected a bunch of problems of placing & more balanced mass.
— Added DesignSpace+UFO source files. Just converted & dumped as they are, for now. There are issues with Masters compatibility. Tested in Glyphs app.

Other fixes
— Fixed construction of † ‡ ∏ ∐  #205 #206
— Added exclusion in /* ligature #88
— Refactored ß
— ~= ligature removed #204
— Added >-> ligature #194
— Added u0336 Long stroke overlay #190
— Added ligature //= #185
— Corrected contour of the arrows in ligatures #196

Known issues
— In Medium weights the height of [ ] { } decreased by one pixel in 12px, 13px sizes. This is a hinting bug.
@philippnurullin
Copy link
Member

The change from =~= to "approximately equal" is to dramatic. Don't see a good way to implement that.

@philippnurullin philippnurullin mentioned this issue Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unicode request Request for adding more symbols
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thebertster @philippnurullin