Skip to content

Commit

Permalink
Merge PR mumble-voip#5521: FIX(installer): Re-add URL protocol regist…
Browse files Browse the repository at this point in the history
…ration registry keys on install

In the installer refactor (88e1786) these registry keys were removed, so new installs did not register a URL protocol and users weren't able to use mumble:// links.
This is a direct translation of Files.wxs to equivalent WixSharp code.

Closes mumble-voip#5473
  • Loading branch information
Krzmbrzl authored Jan 27, 2022
2 parents 0e204e1 + 55be4a6 commit 516d941
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion installer/ClientInstaller.cs
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public ClientInstaller(string version, string arch, Features features) {

for (int i = 0; i < binaries.Count; i++) {
if (binaries[i] == "mumble.exe") {
binaryFiles[i] = new File(@"..\..\" + binaries[i], new FileAssociation("mumble_plugin", "application/mumble", "Open", "\"%1\""));
binaryFiles[i] = new File(new Id("mumble.exe"), @"..\..\" + binaries[i], new FileAssociation("mumble_plugin", "application/mumble", "Open", "\"%1\""));
} else {
binaryFiles[i] = new File(@"..\..\" + binaries[i]);
}
Expand Down Expand Up @@ -183,6 +183,12 @@ public ClientInstaller(string version, string arch, Features features) {
menuDir,
desktopDir
};
this.RegValues = new RegValue[] {
new RegValue(RegistryHive.ClassesRoot, "mumble", "", "URL:Mumble"),
new RegValue(RegistryHive.ClassesRoot, "mumble", "URL Protocol", ""),
new RegValue(RegistryHive.ClassesRoot, @"mumble\DefaultIcon", "", "[#mumble.exe]"),
new RegValue(RegistryHive.ClassesRoot, @"mumble\shell\open\command", "", "[#mumble.exe] \"%1\"")
};
}
}

Expand Down

0 comments on commit 516d941

Please sign in to comment.