-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openai: add python3Packages.wandb dependency #161725
Conversation
Looks like the fixes to the dependencies of I'm running |
The @ofborg failure on Linux seems to be due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mass rebuild is due to changes in pkgs/development/python-modules/dnspython/default.nix
Many python packages depend on this package.
Do you need to change it for openai to work? If so: Please add the changes to dnspython in a seperate PR against staging.
0c11b57
to
0114239
Compare
@gador, Just to confirm, you'd like me to make a new PR with the changes to |
I'd think that's a sensible action, yes. This way, this PR gets reviewed and merged faster and mass rebuilds (due to dnspython) should go to staging (and will take some time to get merged) |
Now only blocked on #161740 hitting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 161725 run on x86_64-linux 1
1 package built:
- openai (python39Packages.openai)
to rebase to staging:
then change the base branch in the github PR from See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch for more details on staging branch |
Motivation for this change
The
openai
executable frompython3Packages.openai
added new functionality that depends onpython3Packages.wandb
. This PR adds that dependency, and also fixes some build issues with packageswandb
depends on.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes