Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai: add python3Packages.wandb dependency #165158

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

malob
Copy link
Member

@malob malob commented Mar 21, 2022

Description of changes

Changes originally submitted in #161725, but since the changes will cause failed builds on darwin until #161740 lands on master (it's currently still only on staging), targeting staging with these changes instead.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: clean-up 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 21, 2022
@SuperSandro2000
Copy link
Member

@malob not sure why the tests fail

@malob
Copy link
Member Author

malob commented Mar 23, 2022

@SuperSandro2000, I don't know either, but it doesn't look like it has anything to do with the changes made by this PR, all 4 builds fail due to issues with dependencies (and on darwin pretty low level dependencies).

For x86_64-darwin this seems to be the issue:

[...]
checking run-time libs availability... failed
configure: error: one or more libs available at link-time are not available run-time. Libs used at link-time: -lnghttp2 -lssh2 -lssh2 -lssl -lcrypto -lssl -lcrypto -lgssapi_krb5 -lresolv -lz
builder for '/nix/store/j1xrg7iihy5hnhc69hjzr7x7wvd8h6sm-curl-7.82.0.drv' failed with exit code 1
cannot build derivation '/nix/store/hm5rfd4537jaij1ga0mgzhm7gl3xvynb-swift-corefoundation-unstable-2018-09-14.drv': 1 dependencies couldn't be built
[...]

On aarch64-darwin:

[...]
0.1.2/bin/sigtool --file "$file" check-requires-signature
Unexpected exit status from sigtool: 134
error: builder for '/nix/store/qh86d3a6a7wc5994zm1wklqcadq0fwki-python3-minimal-3.9.11.drv' failed with exit code 1;
       last 10 log lines:
       > /nix/store/q0vnphbkdcldkjrwp1xs69amf9843yjb-python3-minimal-3.9.11/lib/python3.9/config-3.9-darwin/makesetup
       > /nix/store/q0vnphbkdcldkjrwp1xs69amf9843yjb-python3-minimal-3.9.11/lib/python3.9/config-3.9-darwin/config.c
       > /nix/store/q0vnphbkdcldkjrwp1xs69amf9843yjb-python3-minimal-3.9.11/lib/python3.9/config-3.9-darwin/Setup.local
       > /nix/store/q0vnphbkdcldkjrwp1xs69amf9843yjb-python3-minimal-3.9.11/lib/python3.9/config-3.9-darwin/python.o
       > /nix/store/q0vnphbkdcldkjrwp1xs69amf9843yjb-python3-minimal-3.9.11/lib/python3.9/config-3.9-darwin/libpython3.9.a
       > dyld: Library not loaded: /nix/store/x7sy3ml65vg0h6kkkq01qmwqx5plpj8p-openssl-1.1.1n//libssl.1.1.dylib
       >   Referenced from: /nix/store/c04kqdcdfz3hrw3r2hi69lfmp6qk6mpw-sigtool-0.1.2/bin/sigtool
       >   Reason: image not found
       > /nix/store/p9v74za26sk90p313qmwmkfrm7w2sbx0-signing-utils: line 24: 37225 Abort trap: 6           /nix/store/c04kqdcdfz3hrw3r2hi69lfmp6qk6mpw-sigtool-0.1.2/bin/sigtool --file "$file" check-requires-signature
       > Unexpected exit status from sigtool: 134
       For full logs, run 'nix log /nix/store/qh86d3a6a7wc5994zm1wklqcadq0fwki-python3-minimal-3.9.11.drv'.
error: 1 dependencies of derivation '/nix/store/yx8vjnhsxq58919kr9cdl21nj6da5nam-ICU-66108.drv' failed to build
error: 1 dependencies of derivation '/nix/store/ylxrlp582pqvvi9dq72xik8pl0anjslf-libxml2-2.9.13.drv' failed to build
[...]

For Linux thing seem to get further. I'm going to have a look into those now.

I know that on darwin this change builds on master with #161740 cherry picked.

@malob
Copy link
Member Author

malob commented Mar 23, 2022

Looks like Hydra is having many of the same issues with the same dependencies on staging-next: https://malob.github.io/nix-review-tools-reports/nixpkgs:staging-next/nixpkgs_staging-next_1750665.html

(e.g., curl on x86_64-darwin)

@malob
Copy link
Member Author

malob commented Mar 24, 2022

Rebased to get fixes like 195c7da which should help things.

@SuperSandro2000
Copy link
Member

Now wandb fails to build on staging...

@malob malob force-pushed the openai-add-wandb branch 2 times, most recently from 5e915bb to cc098fb Compare March 28, 2022 23:06
@malob
Copy link
Member Author

malob commented Mar 28, 2022

@SuperSandro2000, just added a commit that fixes the python3Packages.wandb build issue on darwin systems.

(I tested it on master and it worked for me.)

@malob malob changed the base branch from staging to staging-next March 29, 2022 03:15
@malob
Copy link
Member Author

malob commented Mar 29, 2022

Result of nixpkgs-review pr 165158 run on aarch64-darwin 1

6 packages built:
  • openai (python39Packages.openai)
  • python310Packages.openai
  • python310Packages.spacy-loggers
  • python310Packages.wandb
  • python39Packages.spacy-loggers
  • python39Packages.wandb

@malob
Copy link
Member Author

malob commented Mar 29, 2022

Result of nixpkgs-review pr 165158 run on x86_64-darwin 1

6 packages marked as broken and skipped:
  • python310Packages.spacy
  • python310Packages.spacy-transformers
  • python310Packages.textacy
  • python39Packages.spacy
  • python39Packages.spacy-transformers
  • python39Packages.textacy
6 packages built:
  • openai (python39Packages.openai)
  • python310Packages.openai
  • python310Packages.spacy-loggers
  • python310Packages.wandb
  • python39Packages.spacy-loggers
  • python39Packages.wandb

@samuela
Copy link
Member

samuela commented Mar 29, 2022

Result of nixpkgs-review pr 165158 run on aarch64-darwin 1

6 packages built:

How are you getting this result? When I run nixpkgs-review pr 165158 on aarch64-darwin it's starts trying to build hundreds (thousands?) of packages, including everything from coreutils to llvm. Am I missing something?

Copy link
Member

@samuela samuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wandb changes LGTM

wandb builds for me on aarch64-darwin

@malob
Copy link
Member Author

malob commented Mar 29, 2022

How are you getting this result? When I run nixpkgs-review pr 165158 on aarch64-darwin it's starts trying to build hundreds (thousands?) of packages, including everything from coreutils to llvm. Am I missing something?

That sounds right. I've been working on getting this building for a couple of weeks now, and have been running long builds in the background as I've been going to confirm the fixes I've submitted are working on staging/staging-next.

@SuperSandro2000 SuperSandro2000 merged commit e553640 into NixOS:staging-next Mar 29, 2022
@malob malob deleted the openai-add-wandb branch March 29, 2022 17:42
@@ -114,6 +114,10 @@ buildPythonPackage rec {
"tests/test_tables.py"
];

# Disable test that fails on darwin due to issue with python3Packages.psutil:
# https://github.com/giampaolo/psutil/issues/1219
disabledTests = lib.optional stdenv.isDarwin "test_tpu_system_stats";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hindsight, I kinda wish we went with lib.optionals instead (https://discourse.nixos.org/t/lib-optional-considered-harmful/7081), but it's really not a big deal.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants