-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openai: add python3Packages.wandb dependency #165158
Conversation
@malob not sure why the tests fail |
@SuperSandro2000, I don't know either, but it doesn't look like it has anything to do with the changes made by this PR, all 4 builds fail due to issues with dependencies (and on For
On
For Linux thing seem to get further. I'm going to have a look into those now. I know that on |
Looks like Hydra is having many of the same issues with the same dependencies on (e.g., |
Rebased to get fixes like 195c7da which should help things. |
Now wandb fails to build on staging... |
5e915bb
to
cc098fb
Compare
@SuperSandro2000, just added a commit that fixes the (I tested it on |
Result of 6 packages built:
|
Result of 6 packages marked as broken and skipped:
6 packages built:
|
How are you getting this result? When I run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wandb changes LGTM
wandb builds for me on aarch64-darwin
That sounds right. I've been working on getting this building for a couple of weeks now, and have been running long builds in the background as I've been going to confirm the fixes I've submitted are working on |
@@ -114,6 +114,10 @@ buildPythonPackage rec { | |||
"tests/test_tables.py" | |||
]; | |||
|
|||
# Disable test that fails on darwin due to issue with python3Packages.psutil: | |||
# https://github.com/giampaolo/psutil/issues/1219 | |||
disabledTests = lib.optional stdenv.isDarwin "test_tpu_system_stats"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In hindsight, I kinda wish we went with lib.optionals
instead (https://discourse.nixos.org/t/lib-optional-considered-harmful/7081), but it's really not a big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted.
Description of changes
Changes originally submitted in #161725, but since the changes will cause failed builds on
darwin
until #161740 lands onmaster
(it's currently still only onstaging
), targetingstaging
with these changes instead.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes