Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Download table heading #9267

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Update Download table heading #9267

merged 2 commits into from
Oct 12, 2022

Conversation

toseni
Copy link
Contributor

@toseni toseni commented Oct 3, 2022

PR for #8479

@toseni toseni requested a review from a team as a code owner October 3, 2022 19:36
@toseni toseni changed the title update correct place Update Download table heading Oct 3, 2022
@keylime-unicorn
Copy link
Contributor

Thank you for the PR! Can you provide a screenshot of the change?

@toseni
Copy link
Contributor Author

toseni commented Oct 4, 2022

Before:
image

After:
image

Downloads column shifts to the left.
Should I make sure that it does not shift?

@keylime-unicorn
Copy link
Contributor

@clairernovotny Could you take a look at the proposed changes in the screenshot above? Thanks!

@toseni
Copy link
Contributor Author

toseni commented Oct 7, 2022

Used table-layout: fixed to make the shift better.
Initial:
image
After:
image

clairernovotny
clairernovotny previously approved these changes Oct 10, 2022
@keylime-unicorn keylime-unicorn changed the base branch from main to dev October 11, 2022 21:55
@keylime-unicorn keylime-unicorn dismissed stale reviews from clairernovotny and themself October 11, 2022 21:55

The base branch was changed.

@keylime-unicorn keylime-unicorn merged commit d1b6b4c into NuGet:dev Oct 12, 2022
@toseni toseni deleted the patch-1 branch October 12, 2022 20:18
@toseni
Copy link
Contributor Author

toseni commented Oct 13, 2022

Sorry, seems that I haven't completely followed your contributing guidelines.

RiadGahlouz added a commit that referenced this pull request Oct 19, 2022
* Update NuGetGallery.Services to address CG alerts (#9274)

* Address accessibility for syntax highlighting (#9273)

* address accessbility for syntax highlighting

* Fix Support link (#9276)

* fix broken support link

* Update Download table heading (#9267)

* update correct place

* update table header placement

* Add instructions to install MSBuildSdk packages (#9268)

* Added "IsMSBuildSdkPackageType" to determine whether a package is of type MSBuildSdk.

DisplayPackage view modified to show specific instructions for SDK types in project files as per #8800

* Changed "Include" to correct attribute "Name" for SDK package type

Co-authored-by: Advay Tandon <[email protected]>
Co-authored-by: lyndaidaii <[email protected]>

* [CodeQL] Suppress CSRF token validation warnings (#9278)

* Added CSRF token checks to address CodeQL bugs

* Added CodeQL suppressions

* Make thinner border for focused links (#9277)

* Make thiner border for focused links

* Change border size of package manager tabs

* Delete comment line from base.less

* Change nav-tabs color and make overflow-y visible for package-tags

Co-authored-by: Joel Verhagen <[email protected]>
Co-authored-by: lyndaidaii <[email protected]>
Co-authored-by: toseni <[email protected]>
Co-authored-by: Ian Rathbone <[email protected]>
Co-authored-by: Advay Tandon <[email protected]>
Co-authored-by: Daniel Olczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants