-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address accessibility for syntax highlighting #9273
Conversation
This looks like a "surgical" approach. I presume the goal is to minimize the apparent change in how it looks, as opposed to using one of the accessible CSS stylesheets? I see a lot more hex colors mentioned than the two in your PR description. What is the intended scope of changes? What methodology did you use to select the new colors? Could you provide a representative screenshot showing the difference? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions about approach. Overall, looks reasonable though.
The "after" looks great still. Thanks for the additional information, and nice work on the rapid fix. Consider testing a sample on each of the top 10-20 syntax highlighting languages. It's not clear to me that different languages use colors consistently so testing a broad set of languages might be prudent (I'm thinking of you, F# 😄) |
I tested all packages that have accessibility issues with FastPass. Thanks for reminder about other languages test! |
* Update NuGetGallery.Services to address CG alerts (#9274) * Address accessibility for syntax highlighting (#9273) * address accessbility for syntax highlighting * Fix Support link (#9276) * fix broken support link * Update Download table heading (#9267) * update correct place * update table header placement * Add instructions to install MSBuildSdk packages (#9268) * Added "IsMSBuildSdkPackageType" to determine whether a package is of type MSBuildSdk. DisplayPackage view modified to show specific instructions for SDK types in project files as per #8800 * Changed "Include" to correct attribute "Name" for SDK package type Co-authored-by: Advay Tandon <[email protected]> Co-authored-by: lyndaidaii <[email protected]> * [CodeQL] Suppress CSRF token validation warnings (#9278) * Added CSRF token checks to address CodeQL bugs * Added CodeQL suppressions * Make thinner border for focused links (#9277) * Make thiner border for focused links * Change border size of package manager tabs * Delete comment line from base.less * Change nav-tabs color and make overflow-y visible for package-tags Co-authored-by: Joel Verhagen <[email protected]> Co-authored-by: lyndaidaii <[email protected]> Co-authored-by: toseni <[email protected]> Co-authored-by: Ian Rathbone <[email protected]> Co-authored-by: Advay Tandon <[email protected]> Co-authored-by: Daniel Olczyk <[email protected]>
Approach: use our own syntax highlighting css style to have more control over
contrast issue:
Test: Ran few packages with code fence readme with FastPass
Addresses #9269