Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to install MSBuildSdk packages #9268

Merged

Conversation

ianrathbone
Copy link
Contributor

Let me know what you think, I've tested this on a few different packages of different types

advay26 and others added 3 commits September 19, 2022 12:04
[ReleasePrep][2022.09.16]RI of dev into main
[ReleasePrep][2022.09.21]FI of dev into main for NuGetGallery
…type MSBuildSdk.

DisplayPackage view modified to show specific instructions for SDK types in project files as per NuGet#8800
@ianrathbone ianrathbone requested a review from a team as a code owner October 3, 2022 20:13
@ghost
Copy link

ghost commented Oct 3, 2022

CLA assistant check
All CLA requirements met.

nkolev92
nkolev92 previously approved these changes Oct 5, 2022
keylime-unicorn
keylime-unicorn previously approved these changes Oct 5, 2022
@keylime-unicorn keylime-unicorn changed the base branch from main to dev October 11, 2022 21:56
@keylime-unicorn keylime-unicorn dismissed stale reviews from nkolev92 and themself October 11, 2022 21:56

The base branch was changed.

@keylime-unicorn keylime-unicorn merged commit 48dde8e into NuGet:dev Oct 12, 2022
@ianrathbone ianrathbone deleted the Issue8800-MSBuildSdk-Instructions branch October 13, 2022 06:55
RiadGahlouz added a commit that referenced this pull request Oct 19, 2022
* Update NuGetGallery.Services to address CG alerts (#9274)

* Address accessibility for syntax highlighting (#9273)

* address accessbility for syntax highlighting

* Fix Support link (#9276)

* fix broken support link

* Update Download table heading (#9267)

* update correct place

* update table header placement

* Add instructions to install MSBuildSdk packages (#9268)

* Added "IsMSBuildSdkPackageType" to determine whether a package is of type MSBuildSdk.

DisplayPackage view modified to show specific instructions for SDK types in project files as per #8800

* Changed "Include" to correct attribute "Name" for SDK package type

Co-authored-by: Advay Tandon <[email protected]>
Co-authored-by: lyndaidaii <[email protected]>

* [CodeQL] Suppress CSRF token validation warnings (#9278)

* Added CSRF token checks to address CodeQL bugs

* Added CodeQL suppressions

* Make thinner border for focused links (#9277)

* Make thiner border for focused links

* Change border size of package manager tabs

* Delete comment line from base.less

* Change nav-tabs color and make overflow-y visible for package-tags

Co-authored-by: Joel Verhagen <[email protected]>
Co-authored-by: lyndaidaii <[email protected]>
Co-authored-by: toseni <[email protected]>
Co-authored-by: Ian Rathbone <[email protected]>
Co-authored-by: Advay Tandon <[email protected]>
Co-authored-by: Daniel Olczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants