[ReleasePrep][2023.01.26]RI of dev into main #9362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#9349) * add role attribute * add informational comment
* started restructuring the search page * all functional pieces in place * sort by dropwdown UI done-ish * cleaned up a lot, need to add flippable chevrons instead of current 'v' dropdown arrows * closer.... * Added some tests * a11y fixes * Removed placeholders * minor - ready for PR * fixed failing tests * last test standing * Addressed feedback on the PR * whitespace changes * Only cache results when frameworks and tfms aren't selected * addressed a few more comments * minor css fix * whitespace
* Search-by-TFM UI Fix: Input fields were hidden behind feature flight but still being referenced by js changes, which was causing errors * Also moved framework initialization script to end of js file * a11y fix
keylime-unicorn
approved these changes
Jan 26, 2023
|
Waiting to check with Jon on whether we can move the Search-by-TFM UI changes to INT and PROD. The Frameworks filters are going to be behind a feature flight, but users will still see this new UI with the filters on the left and the new Sort by dropdown As compared to this from earlier (DEV vs PROD) |
advay26
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.