Next/20201207/v8 #5638
Closed
Next/20201207/v8 #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the libhtp, suricata-update and suricata-verify directories before uploading the artifact reduces the upload time from minutes to seconds.
Instead of building cbindgen in every build, build it once during prep as a static musl binary to avoid library issues.
Since the completion status was a constant for all parsers, remove the callback logic and instead register the values themselves. This should avoid a lot of unnecessary callback calls. Update all parsers to take advantage of this.
Also use the pre-build cbindgen binary. Hopefully speeds up the build process.
Merged
|
Replaced by #5644 |
cccs-rtmorti
added a commit
to cccs-rtmorti/suricata
that referenced
this pull request
Nov 4, 2022
Use the lzma-rs create for decompressing swf/lzma files instead of the lzma decompressor in libhtp. This decouples suricata from libhtp except for actual http parsing, and means libhtp no longer has to export a lzma decompression interface. Ticket OISF#5638
3 tasks
cccs-rtmorti
added a commit
to cccs-rtmorti/suricata
that referenced
this pull request
Nov 14, 2022
Use the lzma-rs create for decompressing swf/lzma files instead of the lzma decompressor in libhtp. This decouples suricata from libhtp except for actual http parsing, and means libhtp no longer has to export a lzma decompression interface. Ticket: OISF#5638
cccs-rtmorti
added a commit
to cccs-rtmorti/suricata
that referenced
this pull request
Nov 14, 2022
Use the lzma-rs crate for decompressing swf/lzma files instead of the lzma decompressor in libhtp. This decouples suricata from libhtp except for actual http parsing, and means libhtp no longer has to export a lzma decompression interface. Ticket: OISF#5638
3 tasks
cccs-rtmorti
added a commit
to cccs-rtmorti/suricata
that referenced
this pull request
Nov 16, 2022
Use the lzma-rs crate for decompressing swf/lzma files instead of the lzma decompressor in libhtp. This decouples suricata from libhtp except for actual http parsing, and means libhtp no longer has to export a lzma decompression interface. Ticket: OISF#5638
3 tasks
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Dec 2, 2022
Use the lzma-rs crate for decompressing swf/lzma files instead of the lzma decompressor in libhtp. This decouples suricata from libhtp except for actual http parsing, and means libhtp no longer has to export a lzma decompression interface. Ticket: OISF#5638
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Dec 3, 2022
Use the lzma-rs crate for decompressing swf/lzma files instead of the lzma decompressor in libhtp. This decouples suricata from libhtp except for actual http parsing, and means libhtp no longer has to export a lzma decompression interface. Ticket: OISF#5638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5636 with #5637 to test the sccache integration.