Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file/swf: Use lzma-rs decompression instead of libhtp. #8176

Closed
wants to merge 1 commit into from

Conversation

cccs-rtmorti
Copy link
Contributor

Use the lzma-rs crate for decompressing swf/lzma files instead of the lzma decompressor in libhtp. This decouples suricata from libhtp except for actual http parsing, and means libhtp no longer has to export a lzma decompression interface.

Ticket: #5638

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket: 5638

Describe changes:

  • Create a lzma.rs file which exports a lzma decompression function interface.
  • In util-file-swf-decompression.c, use this interface instead of the lzma decompression interface presented by libhtp.
  • Update error types / constants to reflect lzma-rs error conditions / results.

Update to #8171

Use the lzma-rs crate for decompressing swf/lzma files instead of
the lzma decompressor in libhtp. This decouples suricata from libhtp
except for actual http parsing, and means libhtp no longer has to
export a lzma decompression interface.

Ticket: OISF#5638
@catenacyber
Copy link
Contributor

#8183 was merged, so checking CI for this and then looking into rebasing #7438

@victorjulien
Copy link
Member

Failure looks like it is because of not being up to date with master. Currently testing this in a rebased form.

This was referenced Dec 2, 2022
@victorjulien
Copy link
Member

Merged in #8237, thanks a lot @cccs-rtmorti !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants