file/swf: Use lzma-rs decompression instead of libhtp. #8171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the lzma-rs crate for decompressing swf/lzma files instead of the lzma decompressor in libhtp. This decouples suricata from libhtp except for actual http parsing, and means libhtp no longer has to export a lzma decompression interface. Ticket: OISF#5638
3 tasks
victorjulien
requested changes
Nov 15, 2022
| @@ -0,0 +1,68 @@ | |||
| use lzma_rs::decompress::{Options, Stream}; | |||
There was a problem hiding this comment.
can you add a copyright header here?
There was a problem hiding this comment.
Yup! Sorry I forgot it.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8171 +/- ##
==========================================
+ Coverage 81.73% 81.80% +0.07%
==========================================
Files 962 963 +1
Lines 276975 276998 +23
==========================================
+ Hits 226379 226611 +232
+ Misses 50596 50387 -209
Flags with carried forward coverage won't be shown. Click here to find out more. |
catenacyber
reviewed
Nov 16, 2022
| Error::HeaderTooShort(_) => LzmaStatus::LzmaHeaderTooShortError, | ||
| Error::LzmaError(e) => { | ||
| if e.to_string().contains("exceeded memory limit") { | ||
| LzmaStatus::LzmaMemoryError |
catenacyber
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Thanks for this nice work.
CI : ✅
Code : looks good to me, comments were taken into account
Commits segmentation : ok
Commit messages : nice
Git ID set : looks fine for me
CLA : should be fine
Redmine ticket : ok
Rustfmt : fine for new file
Tests : good enough for me with current ones
Dependencies added: MIT License is good
3 tasks
|
Updated in #8176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the lzma-rs crate for decompressing swf/lzma files instead of the lzma decompressor in libhtp. This decouples suricata from libhtp except for actual http parsing, and means libhtp no longer has to export a lzma decompression interface.
Ticket: #5638
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket: 5638
Describe changes:
Update to #8154