Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next/20221202/v4 #8235

Closed
wants to merge 5 commits into from
Closed

Conversation

Thorsten Zachmann and others added 5 commits December 2, 2022 12:24
This fixes issue 4759. The problem is, that when tcp rules are active
in case of a tcp dns connection first the server to client is inspected
and nothing found.

Afterwards the full flow is marked as processed and therefore the dns
query in TCP is not found.

Bug: OISF#4759.
Use the lzma-rs crate for decompressing swf/lzma files instead of
the lzma decompressor in libhtp. This decouples suricata from libhtp
except for actual http parsing, and means libhtp no longer has to
export a lzma decompression interface.

Ticket: OISF#5638
AF_XDP support is a recent technology introduced that aims at improving
capture performance. With this update, Suricata now provides a new
capture source 'af-xdp' that attaches an eBPF program to the network
interface card. Packets received in the NIC queue are forwarded to
a RX ring in user-space, bypassing the Linux network stack.

Note, there is a configuration option (force-xdp-mode) that forces the
packet through the normal Linux network stack.

libxdp and libbpf is required for this feature and is compile time
configured.

This capture source operates on single and multi-queue NIC's via
suricata.yaml. Here, various features can be enabled, disabled
or edited as required by the use case.

This feature currently only supports receiving packets via AF_XDP,
no TX support has been developed.

Ticket: https://redmine.openinfosecfoundation.org/issues/3306

Additional reading:
https://www.kernel.org/doc/html/latest/networking/af_xdp.html
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #8235 (5ea4651) into master (45eb038) will decrease coverage by 0.03%.
The diff coverage is 51.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8235      +/-   ##
==========================================
- Coverage   81.69%   81.65%   -0.04%     
==========================================
  Files         965      968       +3     
  Lines      278507   278604      +97     
==========================================
- Hits       227523   227492      -31     
- Misses      50984    51112     +128     
Flag Coverage Δ
fuzzcorpus 63.70% <31.78%> (-0.03%) ⬇️
suricata-verify 59.44% <33.33%> (-0.04%) ⬇️
unittests 63.28% <49.61%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

field baseline test %
SURI_TLPW1_stats_chk
.tcp.rst 128237 105121 81.97%

Pipeline 11041

@victorjulien victorjulien marked this pull request as draft December 3, 2022 06:21
@victorjulien
Copy link
Member Author

Investigating the dns related QA failures.

@victorjulien
Copy link
Member Author

replaced by #8237 which drops the dns patch

@victorjulien victorjulien deleted the next/20221202/v4 branch January 31, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants