Pass Completion, Rename and Block Structure options directly instead of updating the Workspace #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoeRobich @333fred PTAL |
|
FYI @jasonmalinowski |
333fred
approved these changes
Dec 9, 2021
src/OmniSharp.Roslyn.CSharp/Services/Refactoring/RenameService.cs
Outdated
Show resolved
Hide resolved
|
@tmat looks like the version you updated to doesn't have the updated types? |
JoeRobich
approved these changes
Jan 20, 2022
333fred
approved these changes
Jan 20, 2022
|
Ah, this is now blocked on dotnet/roslyn#58940 |
|
@jasonmalinowski Is O# not using VSMEF? Should it? |
|
We could bump Omnisharp to use VS MEF, but given this is a regression we need to fix anyways I'd say let's just wait for the fix. |
|
The fix on the Roslyn side has been merged, so @tmat we just need to bump the Roslyn version in this PR (...again...). |
…of updating the Workspace. This approach will also apply to the remaining IWorkspaceOptionsProviders once necessary refactorings are complete in Roslyn. Update to Roslyn 4.2.0-1.22074.8
JoeRobich
reviewed
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach will also apply to the remaining IWorkspaceOptionsProviders once necessary refactorings are complete in Roslyn.