Fix solution build file references (Lombiq Technologies: OCORE-180) #16269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hishamco @MikeAlhayek @sebastienros could you please check this ASAP? Because this affects everyone working on the solution from VS (possibly others). |
MikeAlhayek
approved these changes
Jun 10, 2024
|
Such PR might be exceptional Mike :) |
|
I was waiting for approval because even if I did this small change to the best of my abilities, it can be incorrect, like with any PRs :). To be clear, I just pinged you three because since this bug is affecting everyone working on OC, I thought it's important to get reviewed ASAP by any of you. Not because all three of you need to review it. I'll make that clear next time. |
microposmp
pushed a commit
to microposmp/OrchardCore
that referenced
this pull request
Jun 13, 2024
sebastienros
pushed a commit
that referenced
this pull request
Jun 13, 2024
#16274) * Saving workflow fails * Fix solution build file references (#16269) * Remove Gitter references (#16270) * Add serialisation compatibility of TimeSpan and DateTime (#16205) Co-authored-by: Mike Alhayek <[email protected]> Co-authored-by: Hisham Bin Ateya <[email protected]> * Update Azure.Identity 1.11.4 (#16286) * Add rounding. --------- Co-authored-by: Zoltán Lehóczky <[email protected]> Co-authored-by: Tony Han <[email protected]> Co-authored-by: Mike Alhayek <[email protected]> Co-authored-by: Hisham Bin Ateya <[email protected]>
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #16235 you get the following warning in VS:
There aren't any details in the output window apart from a generic "Some of the properties associated with the solution could not be read." but the issue was with the references fixed in this PR.