Skip to content

Commit

Permalink
Fix mozilla#290: Do not allow scrollbars on the entire popup itself.
Browse files Browse the repository at this point in the history
This overflow declaration was added in mozilla#215, nominally to help deal with
overflow issues when pinned to the overflow menu, but it's not clear how this
particular line helps vs the other changes to the width of the onboarding
view.

My theory on why this is biting us now:

- mozilla#256 updated the popup to a fixed width when not in the overflow menu, and a
  flexible width when it is.
- When we have more items than the 600px max height in the popup, we overflow
  and add a vertical toolbar inside.
- The vertical toolbar increases the desired width of the popup, causing the
  body element to add a horizontal scrollbar.
- The horizontal scrollbar increases the height beyond the 600px limit (since
  the initial overflow is contained within the product listing), causing the
  body element to add a vertical scrollbar.

If we force the body element to hide overflow, it refuses to add scrollbars, and
the overflow scrollbar on the product listing is overlaid correctly. This should
be safe to do now that we flex the width of the popup based on where it is
located.
  • Loading branch information
Michael Kelly committed Nov 28, 2018
1 parent fec9c8e commit 4a673dc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/browser_action/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ body {
font-size: 13px;
margin: 0;
max-height: 600px;
overflow: auto;
overflow: hidden;
padding: 0;
}

Expand Down

0 comments on commit 4a673dc

Please sign in to comment.