This repository has been archived by the owner on Dec 3, 2020. It is now read-only.
Fix deploy script and other changes. #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looked over the changes and tested them locally again, they look correct to me. self-r+ |
biancadanforth
added a commit
to biancadanforth/price-tracker
that referenced
this pull request
Nov 5, 2018
… bounds In previous PRs (mozilla#214, mozilla#215 and mozilla#218) CSS fixes were added to partially constrain either the whole popup or sections of it, leaving the 'Undo' section out. This patch puts a min-width and max-width on the whole popup, while flexibly sizing all its child containers, ensuring that the fixes applied in previous PRs remain in place. Unfortunately, the Overflow menu has a width greater than our ideal popup width of 320px per the [UX spec](https://mozilla.invisionapp.com/share/UFNSHAIMT4V#/screens/317130676_Artboard_1), and that width cannot be controlled by a Web Extension, so I have set the max-width to 400px which will ensure the width of the popup doesn't change whether the toolbar button is in the overflow menu or not (previously, it would be one width when opened from the overflow menu and another width when opened otherwise). One idea for the future is to try and detect whether the toolbar button is in the overflow menu or not and change classes accordingly via an experimental API, but that seems like overkill for now.
biancadanforth
added a commit
to biancadanforth/price-tracker
that referenced
this pull request
Nov 6, 2018
… bounds In previous PRs (mozilla#214, mozilla#215 and mozilla#218) CSS fixes were added to partially constrain either the whole popup or sections of it, leaving the 'Undo' section out. This patch puts a min-width and max-width on the whole popup, while flexibly sizing all its child containers, ensuring that the fixes applied in previous PRs remain in place. Unfortunately, the Overflow menu has a width greater than our ideal popup width of 320px per the [UX spec](https://mozilla.invisionapp.com/share/UFNSHAIMT4V#/screens/317130676_Artboard_1), and that width cannot be controlled by a Web Extension, so I have set the max-width to 400px which will ensure the width of the popup doesn't change whether the toolbar button is in the overflow menu or not (previously, it would be one width when opened from the overflow menu and another width when opened otherwise). One idea for the future is to try and detect whether the toolbar button is in the overflow menu or not and change classes accordingly via an experimental API, but that seems like overkill for now.
Osmose
pushed a commit
to Osmose/price-wise
that referenced
this pull request
Nov 28, 2018
This overflow declaration was added in mozilla#215, nominally to help deal with overflow issues when pinned to the overflow menu, but it's not clear how this particular line helps vs the other changes to the width of the onboarding view. My theory on why this is biting us now: - mozilla#256 updated the popup to a fixed width when not in the overflow menu, and a flexible width when it is. - When we have more items than the 600px max height in the popup, we overflow and add a vertical toolbar inside. - The vertical toolbar increases the desired width of the popup, causing the body element to add a horizontal scrollbar. - The horizontal scrollbar increases the height beyond the 600px limit (since the initial overflow is contained within the product listing), causing the body element to add a vertical scrollbar. If we force the body element to hide overflow, it refuses to add scrollbars, and the overflow scrollbar on the product listing is overlaid correctly. This should be safe to do now that we flex the width of the popup based on where it is located.
Osmose
pushed a commit
to Osmose/price-wise
that referenced
this pull request
Nov 28, 2018
This overflow declaration was added in mozilla#215, nominally to help deal with overflow issues when pinned to the overflow menu, but it's not clear how this particular line helps vs the other changes to the width of the onboarding view. My theory on why this is biting us now: - mozilla#256 updated the popup to a fixed width when not in the overflow menu, and a flexible width when it is. - When we have more items than the 600px max height in the popup, we overflow and add a vertical toolbar inside. - The vertical toolbar increases the desired width of the popup, causing the body element to add a horizontal scrollbar. - The horizontal scrollbar increases the height beyond the 600px limit (since the initial overflow is contained within the product listing), causing the body element to add a vertical scrollbar. If we force the body element to hide overflow, it refuses to add scrollbars, and the overflow scrollbar on the product listing is overlaid correctly. This should be safe to do now that we flex the width of the popup based on where it is located.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pile of tiny fixes that I'm comfortable self-reviewing in order to get a new release out tonight: