Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

A horizontal and an extra vertical scrollbar are wrongly displayed after the sixth item is added to the "Products list" #290

Closed
Softvision-RemusDranca opened this issue Nov 28, 2018 · 1 comment
Assignees
Labels
[ENG]: Reserve Low-priority work related to a specific milestone. [QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@Softvision-RemusDranca
Copy link

[Affected versions]:

  • Firefox 63.0.3 and above

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • Have a Firefox profile with the latest version of the "Price Wise" add-on (16.00) downloaded from (download link).
  • Have 5 products added to the "Products list".

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and navigate to "https://www.amazon.com/".
  2. Navigate to a product page (eg.: product).
  3. Click the "Price Wise" toolbar button.
  4. Click "Add This Product" button and observe the doorhanger.

[Expected result]:

  • Only a vertical scrollbar is displayed on the right side of the doorhanger.

[Actual result]:

  • A horizontal scrollbar is displayed at the bottom of the doorhanger and also an extra vertical scrollbar on the right side of the doorhanger.

[Notes]:

  • This issue is not reproducible on TP version.
  • On Windows and Mac OS'es the scrollbars are not longer displayed after the doorhanger is dismissed and reopen. But, on Linux the scrollbars are still displayed after the doorhanger is dismissed.
  • Attached is a screen recording of the issue:
    scrollbars
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Major issue Label for QA to mark major issues logged label Nov 28, 2018
@biancadanforth biancadanforth self-assigned this Nov 28, 2018
@biancadanforth biancadanforth added the [ENG]: Reserve Low-priority work related to a specific milestone. label Nov 28, 2018
@Osmose Osmose assigned Osmose and unassigned biancadanforth Nov 28, 2018
Osmose pushed a commit to Osmose/price-wise that referenced this issue Nov 28, 2018
This overflow declaration was added in mozilla#215, nominally to help deal with
overflow issues when pinned to the overflow menu, but it's not clear how this
particular line helps vs the other changes to the width of the onboarding
view.

My theory on why this is biting us now:

- mozilla#256 updated the popup to a fixed width when not in the overflow menu, and a
  flexible width when it is.
- When we have more items than the 600px max height in the popup, we overflow
  and add a vertical toolbar inside.
- The vertical toolbar increases the desired width of the popup, causing the
  body element to add a horizontal scrollbar.
- The horizontal scrollbar increases the height beyond the 600px limit (since
  the initial overflow is contained within the product listing), causing the
  body element to add a vertical scrollbar.

If we force the body element to hide overflow, it refuses to add scrollbars, and
the overflow scrollbar on the product listing is overlaid correctly. This should
be safe to do now that we flex the width of the popup based on where it is
located.
@Osmose Osmose closed this as completed in 9e78d8b Nov 28, 2018
Osmose added a commit that referenced this issue Nov 28, 2018
Fix #290: Do not allow scrollbars on the entire popup itself.
@muccimoz muccimoz added this to the Post-Launch Development-1 milestone Nov 28, 2018
@Softvision-RemusDranca
Copy link
Author

I have verified this issue using the latest Price Wise version (16.0.0) custom build on 11/29/2018, and the issue is no longer reproducible. Tested on Windows 10 x64, Mac 10.13 and Ubuntu 18.04 x64.

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[ENG]: Reserve Low-priority work related to a specific milestone. [QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

4 participants