Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pypsa eur sec #484

Merged
merged 1,211 commits into from
Mar 18, 2023
Merged

Merge pypsa eur sec #484

merged 1,211 commits into from
Mar 18, 2023

Conversation

fneum
Copy link
Member

@fneum fneum commented Mar 6, 2023

Closes #463
Closes #450
Closes #613
Closes #612

Checklist

  • migrate PRs from pypsa-eur-sec
  • harmonize solve_network @FabianHofmann
  • CI
  • modularization of Snakefile
  • enable/disable progressbar
  • documentation with instructions (how to run elec only etc.) @fneum
  • release notes @fneum

fneum and others added 30 commits February 6, 2023 09:46
test configs: reduce to relative changes
CI: use snakemake --configfile options
Integrate linopy as solver framework
Snakefile: retrieve data bundle from pypsaeur function
automatically retrieve technology-data, no git clone
build sequestration: fix input for new snakemake versions
compatibility with technology-data v0.5
@FabianHofmann FabianHofmann marked this pull request as ready for review March 16, 2023 12:22
@FabianHofmann
Copy link
Contributor

FabianHofmann commented Mar 16, 2023

I had a rough look at the docs and I think they are nicely structured, thanks @fneum! I would be fine with merging at this point. Bug fixing can be done anyway in the new master. Sidenote: I think it would be good to introduce a config directory with a test subdir, for having clearer distinctions (we can do this after merging).

@lisazeyen
Copy link
Contributor

looks really great @fneum, @FabianHofmann . I had a look at the documentation and tried one electricity only, one sector-coupled and one myopic run, all worked nice and smoothly!

@FabianHofmann
Copy link
Contributor

According to our todo list, the only thing missing is the final releases of pypsa-eur(-sec) before merging. However looking at the changes in pypsa-eur since the release, none of it is functional (version fixes, tqdm, cluster wildcard). So I don't even know whether this is necessary. So, I am happy with merging as is anytime :)

@fneum
Copy link
Member Author

fneum commented Mar 18, 2023

Alright, I agree that we don't need new independent releases before merging because 0.7.0 was very recent and because no functional changes were made since then.

Ok, since @lisazeyen, @FabianHofmann, @fneum are happy, and @nworbmot reviewed the docs, let's move ahead!

@fneum fneum merged commit 4a61faf into master Mar 18, 2023
@fneum fneum deleted the merge-pypsa-eur-sec branch March 18, 2023 12:12
@FabianHofmann
Copy link
Contributor

Whoop!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants