Add momentum() function for psp #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szabo137
reviewed
Jul 8, 2024
16 tasks
AntonReinhard
force-pushed
the
momentum_function
branch
from
5fd63a2 to
cc6ef89
Compare
Good idea, I pushed it. |
I just realized that with the |
AntonReinhard
force-pushed
the
momentum_function
branch
from
cc6ef89 to
d12a99a
Compare
It does not add overhead :) |
szabo137
reviewed
Jul 9, 2024
AntonReinhard
force-pushed
the
momentum_function
branch
from
4bde5b3 to
7ba8860
Compare
szabo137
approved these changes
Jul 10, 2024
szabo137
pushed a commit
that referenced
this pull request
Jul 11, 2024
AntonReinhard
added a commit
to AntonReinhard/QEDbase.jl
that referenced
this pull request
Jul 11, 2024
Adds functions
```Julia
momentum(psp::AbstractPhaseSpacePoint, dir::ParticleDirection, species::AbstractParticleType, n::Val{N})
momentum(psp::AbstractPhaseSpacePoint, dir::ParticleDirection, species::AbstractParticleType, n::Int)
```
to get the momentum of the n-th particle of the given species and
direction from the `AbstractPhaseSpacePoint`. I provided two overloads:
One with a compile-time constant N via `Val{N}` and one with a normal
`n::Int`. The first one adds no overhead and is compiled away
completely, but only if the given value is actually a compile-time
constant, such as a literal `1`.
The second overload is implemented separately and is faster than the
first when `n` is not a compile-time constant. It still takes ~40ns on
my machine, versus ~1ns when the first overload is used. The first
overload with a dynamic value (`Val(n)` on variable n) takes ~100ns.
Currently I can't add automated unit tests here yet, since the tests are
in QEDcore still.
AntonReinhard
added a commit
to AntonReinhard/QEDbase.jl
that referenced
this pull request
Jul 11, 2024
Adds the process test from QEDcore to QEDbase in order to test the implementations relying on the process interface. Once QEDjl-project#95, QEDjl-project#90, and QEDjl-project#88 are merged, I can add tests for their functionalities here as well.
AntonReinhard
added a commit
to AntonReinhard/QEDbase.jl
that referenced
this pull request
Jul 11, 2024
Adds functions
```Julia
momentum(psp::AbstractPhaseSpacePoint, dir::ParticleDirection, species::AbstractParticleType, n::Val{N})
momentum(psp::AbstractPhaseSpacePoint, dir::ParticleDirection, species::AbstractParticleType, n::Int)
```
to get the momentum of the n-th particle of the given species and
direction from the `AbstractPhaseSpacePoint`. I provided two overloads:
One with a compile-time constant N via `Val{N}` and one with a normal
`n::Int`. The first one adds no overhead and is compiled away
completely, but only if the given value is actually a compile-time
constant, such as a literal `1`.
The second overload is implemented separately and is faster than the
first when `n` is not a compile-time constant. It still takes ~40ns on
my machine, versus ~1ns when the first overload is used. The first
overload with a dynamic value (`Val(n)` on variable n) takes ~100ns.
Currently I can't add automated unit tests here yet, since the tests are
in QEDcore still.
AntonReinhard
added a commit
to AntonReinhard/QEDbase.jl
that referenced
this pull request
Jul 11, 2024
Adds the process test from QEDcore to QEDbase in order to test the implementations relying on the process interface. Once QEDjl-project#95, QEDjl-project#90, and QEDjl-project#88 are merged, I can add tests for their functionalities here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functions
to get the momentum of the n-th particle of the given species and direction from the
AbstractPhaseSpacePoint. I provided two overloads: One with a compile-time constant N viaVal{N}and one with a normaln::Int. The first one adds no overhead and is compiled away completely, but only if the given value is actually a compile-time constant, such as a literal1.The second overload is implemented separately and is faster than the first when
nis not a compile-time constant. It still takes ~40ns on my machine, versus ~1ns when the first overload is used. The first overload with a dynamic value (Val(n)on variable n) takes ~100ns.Currently I can't add automated unit tests here yet, since the tests are in QEDcore still.