Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the interface for momentum generation #95

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Fix the interface for momentum generation #95

merged 3 commits into from
Jul 9, 2024

Conversation

AntonReinhard
Copy link
Member

Closes #74

@AntonReinhard AntonReinhard requested a review from szabo137 July 5, 2024 15:29
szabo137
szabo137 reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of that. Do you mind adding some unit tests to that using the test implementation already there?

@szabo137 szabo137 added this to the Release-next milestone Jul 8, 2024
@szabo137 szabo137 mentioned this pull request Jul 8, 2024
Closed
16 tasks
@AntonReinhard
Copy link
Member Author

Thanks for taking care of that. Do you mind adding some unit tests to that using the test implementation already there?

I agree, there need to be tests for this. Though maybe we should combine this with porting the tests that are currently in QEDcore back here, since there are already process interface tests there. I would then also add some tests for the functionalities added in the other recent pull requests.
I think it makes more sense to do that in a separate PR though.

@AntonReinhard AntonReinhard force-pushed the fix_gen_momenta_interface branch from 276d979 to 778fea2 Compare July 9, 2024 10:17
@AntonReinhard AntonReinhard mentioned this pull request Jul 9, 2024
Merged
@AntonReinhard AntonReinhard force-pushed the fix_gen_momenta_interface branch from 4fa8ff9 to b82e80f Compare July 9, 2024 17:33
szabo137
szabo137 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Thanks for fixing this.

@AntonReinhard AntonReinhard merged commit 1481a81 into QEDjl-project:dev Jul 9, 2024
4 checks passed
@AntonReinhard AntonReinhard deleted the fix_gen_momenta_interface branch July 9, 2024 19:12
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 10, 2024
@AntonReinhard
Add generate momenta test (for PR QEDjl-project#95)
9519b63
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 10, 2024
@AntonReinhard
Add generate momenta test (for PR QEDjl-project#95)
a86a53c
szabo137 pushed a commit that referenced this pull request Jul 11, 2024
@AntonReinhard
Add process interface test (#96)
68f1fc9 
Adds the process test from QEDcore to QEDbase in order to test the
implementations relying on the process interface.
Once #95, #90, and #88 are merged, I can add tests for their
functionalities here as well.
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 11, 2024
@AntonReinhard
Fix the interface for momentum generation (QEDjl-project#95)
bc069be 
Closes QEDjl-project#74
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 11, 2024
@AntonReinhard
Add process interface test (QEDjl-project#96)
d19d5fe 
Adds the process test from QEDcore to QEDbase in order to test the
implementations relying on the process interface.
Once QEDjl-project#95, QEDjl-project#90, and QEDjl-project#88 are merged, I can add tests for their
functionalities here as well.
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 11, 2024
@AntonReinhard
Fix the interface for momentum generation (QEDjl-project#95)
1037717 
Closes QEDjl-project#74
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 11, 2024
@AntonReinhard
Add process interface test (QEDjl-project#96)
24fe4fa 
Adds the process test from QEDcore to QEDbase in order to test the
implementations relying on the process interface.
Once QEDjl-project#95, QEDjl-project#90, and QEDjl-project#88 are merged, I can add tests for their
functionalities here as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabo137 szabo137 szabo137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release-0.2.2
Development

Successfully merging this pull request may close these issues.

Rework _generate_momenta interface
2 participants
@AntonReinhard @szabo137