Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add number_particles overloads #90

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Add number_particles overloads #90

merged 2 commits into from
Jul 9, 2024

Conversation

AntonReinhard
Copy link
Member

Add functions:

number_particles(proc_def::AbstractProcessDefinition, dir::ParticleDirection, species::AbstractParticleType)
number_particles(proc_def::AbstractProcessDefinition, particle::AbstractParticleStateful)
number_particles(proc_def::AbstractProcessDefinition, particle_type::Type{AbstractParticleStateful})

Closes #89

@AntonReinhard AntonReinhard requested a review from szabo137 July 5, 2024 14:09
szabo137
szabo137 reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. There is just a minor quirk to be addressed.

src/interfaces/process.jl Outdated Show resolved Hide resolved
src/interfaces/process.jl Outdated Show resolved Hide resolved
@szabo137 szabo137 added this to the Release-next milestone Jul 8, 2024
@szabo137 szabo137 mentioned this pull request Jul 8, 2024
Closed
16 tasks
@AntonReinhard AntonReinhard mentioned this pull request Jul 9, 2024
Merged
@AntonReinhard AntonReinhard force-pushed the process_interface_extension branch from d05ad18 to 1dc726b Compare July 9, 2024 09:56
@AntonReinhard
Copy link
Member Author

Quick interesting note on performance: Julia is able to compile the count call away completely, so doing a recursive implementation on the types is not actually necessary.

@AntonReinhard AntonReinhard mentioned this pull request Jul 9, 2024
Merged
@szabo137 szabo137 merged commit 6c227ce into QEDjl-project:dev Jul 9, 2024
4 checks passed
@AntonReinhard AntonReinhard deleted the process_interface_extension branch July 9, 2024 17:34
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 10, 2024
@AntonReinhard
Add particles/number_particles tests (for PR QEDjl-project#90)
8140f96
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 10, 2024
@AntonReinhard
Add particles/number_particles tests (for PR QEDjl-project#90)
5ee78b5
szabo137 pushed a commit that referenced this pull request Jul 11, 2024
@AntonReinhard
Add process interface test (#96)
68f1fc9 
Adds the process test from QEDcore to QEDbase in order to test the
implementations relying on the process interface.
Once #95, #90, and #88 are merged, I can add tests for their
functionalities here as well.
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 11, 2024
@AntonReinhard
Add number_particles overloads (QEDjl-project#90)
0046cbf
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 11, 2024
@AntonReinhard
Add process interface test (QEDjl-project#96)
d19d5fe 
Adds the process test from QEDcore to QEDbase in order to test the
implementations relying on the process interface.
Once QEDjl-project#95, QEDjl-project#90, and QEDjl-project#88 are merged, I can add tests for their
functionalities here as well.
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 11, 2024
@AntonReinhard
Add number_particles overloads (QEDjl-project#90)
0775747
AntonReinhard added a commit to AntonReinhard/QEDbase.jl that referenced this pull request Jul 11, 2024
@AntonReinhard
Add process interface test (QEDjl-project#96)
24fe4fa 
Adds the process test from QEDcore to QEDbase in order to test the
implementations relying on the process interface.
Once QEDjl-project#95, QEDjl-project#90, and QEDjl-project#88 are merged, I can add tests for their
functionalities here as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabo137 szabo137 szabo137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release-0.2.2
Development

Successfully merging this pull request may close these issues.

ProcessDefinition interface extension
2 participants
@AntonReinhard @szabo137